Re: [PATCH v5 0/3] Latest Roccat HID fixes

[Benjamin Tissoires <bentiss@kernel.org>]

Hi Dmitry,

On Sep 29 2026, Dmitry Antipov wrote:
> Now d76994443eed ("HID: roccat: fix locking in roccat_connect() and
> roccat_disconnect()") is landed, and these ones are expected to fix
> https://syzkaller.appspot.com/bug?extid=d632e93ffcd1452bc61e and
> https://syzkaller.appspot.com/bug?extid=c492a9e154f81127551f.
> 
> Dmitry Antipov (3):
>   HID: roccat: use device_is_registered() to check whether device is available

The Sashiko report is actually more concerning than anything. Given
that, I don't think we should keep the patch in the series. Unless you
manage to fix all Sashiko comments, but it feels like a lot of effort
for little gain.

>   HID: roccat: fix device access in roccat_release()

I took this one (see other confirmation email).

>   HID: roccat: use kref to manage device instances

I wanted to take this one but it doesn't apply cleanly with patch 1
dropped. Can you respin it on top of for-7.4/roccat, please?


Cheers,
Benjamin

> 
>  drivers/hid/hid-roccat.c | 63 +++++++++++++++++++++++-----------------
>  1 file changed, 37 insertions(+), 26 deletions(-)
> 
> -- 
> 2.55.0
> 
>