From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB4DA4F96B9; Mon, 19 Oct 2026 14:17:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792419472; cv=none; b=rIRd0iy5NiEuBtD6HiWDOzWYFDgb5cbX6TtSyqJxxa1+N6Yo1uLkpytytz34yBR3iKRAzsqZUKxBMwTaReTBNNN+NgOz1Rr116MT5bkobS4xvp630H/KsUF7qE+cLjEHy5pm6BFOVlNGhkeNmnhzg0DXYbGEiaMTAnGbK2iz7SI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792419472; c=relaxed/simple; bh=ybd3RMKLk8UzOSctVZ4igUBt2OoAf+H6jNbegGq1x9U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EcvS/wiX4u9ZNjQ9GLch2Q2edWHjfnPJs0BViPESCHTJdKxarDnFOhel9KQTsiAiH4dvNNuVL0644Jf58ZFKf2D2zMt/o02deXqgx/E5uacz08yYyBXrCJPiiSIX4+YYIdzJEwGeccIsZFlMGr0olUJSn7kktBDp9ZN4ZEZt9rY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=timmermann.space; spf=pass smtp.mailfrom=timmermann.space; dkim=pass (2048-bit key) header.d=timmermann.space header.i=@timmermann.space header.b=d9qmCoZw; arc=none smtp.client-ip=80.241.56.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=timmermann.space Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=timmermann.space Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=timmermann.space header.i=@timmermann.space header.b="d9qmCoZw" Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4j7d150VHmz8tVt; Mon, 19 Oct 2026 16:17:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timmermann.space; s=MBO0001; t=1792419465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6PLBPDXxkh3JA0G8W5MUw7ro8kFkYJAvC/ayKENpzFo=; b=d9qmCoZwS9DveT8hVG6HQp79Uzj2L3tD254UNI9UmriRArjVLik7wgmIg6MHc6dX74SNz+ 0BvIm3XNz4IVArbXEFWNyhzfbWeeDMwOqXwKx1pCr6YiP8/R2O+vc8VAJSjf4FT1QusDwi XhyWBuFbiYfzawiua/wdgeLNQxlfiWbeTdeuSxS+G0TtB8bV9Eu4dzrPhbHVDAp5JAzDRz S7dFgTFOJeAioa5fzCauvIp4VuYNSXVf43dk9JUrn96vOXathyLqcJjhgc92cjXD/87RCO wdkDQS6Nl7/7EBTzPmpDYHCUkbOhkdXUME9mRtOvUJmD97CD/gjqmbJ+P3f5+w== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of linux@timmermann.space designates 2001:67c:2050:b231:465::102 as permitted sender) smtp.mailfrom=linux@timmermann.space Date: Mon, 19 Oct 2026 16:17:41 +0200 From: Lukas Timmermann To: Krzysztof Kozlowski , Lukas Timmermann , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andi Shyti , Peter Griffin , =?utf-8?B?QW5kcsOp?= Draszik , Tudor Ambarus , Alim Akhtar Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 1/7] dt-bindings: input: touchscreen: samsung,s6sy761: Add S6SY791 and reset GPIO Message-ID: References: <20261011-lat3st-google-raven-touch-upstream-v1-0-2a9f55159b9e@timmermann.space> <20261011-lat3st-google-raven-touch-upstream-v1-1-2a9f55159b9e@timmermann.space> <0a486a08-8d6c-4ca5-8a54-e7499630095c@kernel.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a486a08-8d6c-4ca5-8a54-e7499630095c@kernel.org> X-Rspamd-Queue-Id: 4j7d150VHmz8tVt On Mon, Oct 12, 2026 at 01:30:48PM +0200, Krzysztof Kozlowski wrote: > On 11/10/2026 14:44, Lukas Timmermann wrote: > > S6SY791 is the SPI-based counterpart of S6SY761. The register map and > > commands are identical for the subset the kernel currently implements. > > Therefore add S6SY791 as a related touch controller. > > > > Optionally, the reset line can be controlled on some boards, > > such as the Google Pixel 6 Pro (raven). > > > > Also reference spi-peripheral-props for the SPI bus properties. > > > > Signed-off-by: Lukas Timmermann > > --- > > .../input/touchscreen/samsung,s6sy761.yaml | 37 +++++++++++++++++++++- > > 1 file changed, 36 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml b/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml > > index 1ffd17af3c53..d24f35038934 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/samsung,s6sy761.yaml > > @@ -8,13 +8,17 @@ title: Samsung S6SY761 touchscreen controller > > > > maintainers: > > - Andi Shyti > > + - Lukas Timmermann > > > > allOf: > > - $ref: touchscreen.yaml# > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# Should I also hide this behind an if-else? > > > > properties: > > compatible: > > - const: samsung,s6sy761 > > + enum: > > + - samsung,s6sy761 > > + - samsung,s6sy791 > > > > reg: > > maxItems: 1 > > @@ -22,9 +26,19 @@ properties: > > interrupts: > > maxItems: 1 > > > > + reset-gpios: > > + maxItems: 1 > > + description: GPIO connected to the reset pin of the controller > > + > > avdd-supply: true > > vdd-supply: true > > > > + spi-max-frequency: true > > Drop > Noted. > > + > > + spi-cpha: true > > + > > + spi-cpol: true > > These two should be probably required for the new device. > Thanks. Best regards, Lukas