Re: [PATCH] Input: atkbd - skip deactivate for Xiaomi Redmi Book Pro 14 2026

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Jame,

On Sat, Oct 17, 2026 at 01:03:47AM -0400, Jame Jao wrote:
> Hi Dmitry,
> 
> thanks, the quirk works.  Patch below; it is also attached as
> atkbd-tm2426.patch in case anything gets wrapped on the way.
> 
> Test setup: Xiaomi Redmi Book Pro 14 2026, board TM2426, BIOS RMAPT4B0P0909
> (2026-05-21).  Arch linux-zen 7.2.9 build with this patch on top; the only
> other local change in that build is an unrelated platform/x86
> suspend/resume patch, input code is otherwise untouched.
> 
> With i8042.dumbkbd=1 removed from the kernel command line and the quirk
> active:
> 
>   uname -r        7.2.9-zen1-1.2-zen
> 
>   /proc/bus/input/devices
>   N: Name="AT Translated Set 2 keyboard"
>   P: Phys=isa0060/serio0/input0
>   H: Handlers=sysrq kbd leds event3
>   B: EV=120013          (EV_LED is present; dumbkbd used to give EV=100013)
> 
>   /sys/class/leds
>   input3::capslock  input3::numlock  input3::scrolllock
> 
>   writing input3::capslock/brightness 1 then 0 round-trips, and the Caps
>   Lock lamp follows the key again.
> 
> The built-in keyboard produced 127 key events with 34 distinct key codes
> during the test, so it really is usable without the workaround.
> 
> Minor observation: the two "Spurious ACK" lines in dmesg come from an old
> local userspace helper that pokes /dev/port for the LED; that helper is
> redundant now and I am removing it.
> 
> From: Eason <jaojame6@gmail.com>
> Subject: [PATCH] Input: atkbd - skip deactivate for Xiaomi Redmi Book
> Pro 14 2026
> 
> The built-in keyboard of the Xiaomi Redmi Book Pro 14 2026 (board TM2426)
> types in GRUB but stops delivering keystrokes once the kernel has booted.
> The same failure mode is already handled for the sibling machines
> "Xiaomi Book Pro 14" (TM2424) and "REDMI Book Pro 16 2026" (TM2425) by
> skipping ATKBD_CMD_RESET_DIS in atkbd_probe(), which the embedded
> controller that emulates the PS/2 keyboard does not survive.
> 
> Add the TM2426 DMI entry with the same callback.  Testing without
> i8042.dumbkbd=1 on this machine, the built-in keyboard delivers key
> events again, and the driver now registers the LED class devices that
> dumbkbd used to remove (input3::capslock, input3::numlock,
> input3::scrolllock).  Writing input3::capslock/brightness round-trips and
> the Caps Lock lamp follows the key again.
> 
> Tested-by: Eason <jaojame6@gmail.com>
> Signed-off-by: Eason <jaojame6@gmail.com>

Thank you for the patch but why the From and SOB does not match the
sender?

Thanks.

-- 
Dmitry