Linux Input/HID development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: A Kishki <alaa6394@gmail.com>,
	Nirujogi Pratap <pratap.nirujogi@amd.com>,
	Bin Du <bin.du@amd.com>
Cc: testyiprywatnosc@gmail.com, benjamin.tissoires@redhat.com,
	jikos@kernel.org, linux-input@vger.kernel.org,
	lovekeshsolanki00@gmail.com, linux-i2c@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [BUG] HID: i2c-hid: ELAN 04F3:30FD touchpad reset race causes -EREMOTEIO on HP Pavilion Gaming 15-ec1xxx
Date: Mon, 16 Nov 2026 16:25:00 +0200	[thread overview]
Message-ID: <avsSPIIx4pM8zsj8@ashevche-desk.local> (raw)
In-Reply-To: <CAO6oLZEsN5gkaDvS97i_7bgPFOE-5eX8WjmGcWCcYHvTMQm9Kw@mail.gmail.com>

On Mon, Nov 16, 2026 at 01:54:34PM +0100, A Kishki wrote:
> 
> I found the cause on the same laptop. It is the SDA hold time of the
> touchpad's I2C controller, not a reset race in i2c-hid.
> 
> Machine: HP Pavilion Gaming Laptop 15-ec1xxx, board 87B1, BIOS F.25
> (08/18/2021), Ubuntu kernel 7.0.0-43-generic.
> 
> IC_SDA_HOLD of AMDI0010:03 (0xfedc5000 + 0x7c):
> 
>   normal boot, touchpad dead:         0x00010001
>   boot via HP startup menu, works:    0x00010048
> 
> The ACPI tables give no hold time for this controller, so
> i2c_dw_set_sda_hold() keeps the value it finds ("Keep previous hold
> time setting if no one set it"). After a normal boot that is the reset
> value, a TX hold of one clock, so the touchpad NACKs its address. The
> startup-menu path leaves 0x48, which is why the F9 and UEFI-setup
> workarounds help, and probably why the live ISOs worked, if they were
> booted from the F9 menu.
> 
> To confirm, in a failed boot I unbound AMDI0010:03 from i2c_designware,
> wrote 0x00010048 to the register through /dev/mem and bound it again.
> The touchpad probed at once and works with hid-multitouch. A rebind
> without the write changes nothing, because the driver reads the same
> value back.
> 
> I run this as a boot-time workaround:
> https://github.com/AhmedKishki/hp-pavilion-15-ec1-touchpad-fix
> 
> A real fix probably belongs in i2c-designware, for example a DMI quirk
> that sets the hold time for this model. I'm happy to test patches.

I think you can ask AMD people to help with the patch cooking.
I Cc'ed maintainers of AMDISP, hopefully they help, or at least lead
you to one who may help.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-16 14:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 12:54 [BUG] HID: i2c-hid: ELAN 04F3:30FD touchpad reset race causes -EREMOTEIO on HP Pavilion Gaming 15-ec1xxx A Kishki
2026-11-16 14:25 ` Andy Shevchenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-08-10 17:31 Adam
2026-08-14 10:38 ` Adam
2026-08-15 19:33 ` Lovekesh Solanki
2026-08-16 17:52   ` Adam
2026-08-16 19:57     ` Adam
2026-08-23 16:02       ` Adam
2026-08-24 18:58         ` Lovekesh Solanki
2026-08-27 21:44           ` Adam
2026-09-06 16:13             ` Adam
     [not found]             ` <CAEru=6+AJAJDw4uCi0=HFXH8XrOQhixHFk2e__o+hdd1m1ju5A@mail.gmail.com>
2026-09-07 20:50               ` Lovekesh Solanki
2026-09-13 21:16                 ` Adam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avsSPIIx4pM8zsj8@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=alaa6394@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=bin.du@amd.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jikos@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=lovekeshsolanki00@gmail.com \
    --cc=pratap.nirujogi@amd.com \
    --cc=testyiprywatnosc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox