From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fenglin Wu <quic_fenglinw@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com,
quic_kamalw@quicinc.com, jestar@qti.qualcomm.com,
quic_huliu@quicinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support
Date: Thu, 27 Jul 2023 10:29:00 +0200 [thread overview]
Message-ID: <b0999940-8cd1-349d-9bf4-d6494145254c@linaro.org> (raw)
In-Reply-To: <f1286da7-05a6-c8aa-d13b-075c0fd45b77@quicinc.com>
On 27/07/2023 09:54, Fenglin Wu wrote:
>>>> + - enum:
>>>> + - qcom,pm7550ba-vib
>>>> + - const: qcom,pm7325b-vib
>>>>
>>>
>>> Yes
>>
>> I wonder why this approved change turned out to something incorrect in
>> your v3 patch...
>>
> Since I got review comments in the driver change and I was told to
> refactor the driver before adding new HW support. I added the HW type
> logic in the driver and I was thinking it might be good to add some
> generic compatible strings to match with the HW type introduced in the
> driver change.
>
> Anyway, I will update it to what you suggested in next patch.
Drivers are not really related to bindings, so whatever HW type you add
in driver, is not a reason to change bindings. Reason to change bindings
could be for example: because hardware is like that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-27 8:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230718062639.2339589-1-quic_fenglinw@quicinc.com>
2023-07-18 6:26 ` [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Fenglin Wu
2023-07-18 6:33 ` Krzysztof Kozlowski
2023-07-18 6:38 ` Fenglin Wu
2023-07-18 7:06 ` Fenglin Wu
2023-07-18 7:20 ` Krzysztof Kozlowski
2023-07-18 7:59 ` Fenglin Wu
2023-07-18 8:02 ` Krzysztof Kozlowski
2023-07-27 7:10 ` Krzysztof Kozlowski
2023-07-27 7:54 ` Fenglin Wu
2023-07-27 8:29 ` Krzysztof Kozlowski [this message]
2023-07-27 10:51 ` Fenglin Wu
2023-07-18 10:51 ` Konrad Dybcio
2023-07-18 10:56 ` Fenglin Wu
2023-07-18 6:26 ` [PATCH v2 2/2] Input: pm8xxx-vib - Add support for more PMICs Fenglin Wu
2023-07-18 6:44 ` Dmitry Baryshkov
2023-07-18 6:58 ` Fenglin Wu
2023-07-18 9:41 ` Dmitry Baryshkov
2023-07-18 10:55 ` Fenglin Wu
2023-07-18 11:04 ` Dmitry Baryshkov
2023-07-19 4:09 ` Fenglin Wu
2023-07-19 8:02 ` Dmitry Baryshkov
2023-07-19 8:24 ` Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0999940-8cd1-349d-9bf4-d6494145254c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jestar@qti.qualcomm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_fenglinw@quicinc.com \
--cc=quic_huliu@quicinc.com \
--cc=quic_kamalw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).