From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFB3C001E0 for ; Thu, 27 Jul 2023 08:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232930AbjG0Iqg (ORCPT ); Thu, 27 Jul 2023 04:46:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233070AbjG0IqN (ORCPT ); Thu, 27 Jul 2023 04:46:13 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CC1A8A63 for ; Thu, 27 Jul 2023 01:29:05 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-99b9161b94aso88833766b.1 for ; Thu, 27 Jul 2023 01:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690446543; x=1691051343; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vqiw6r+PHEVT+EztfpBhphT+HL4dVYUe7akOolTO95E=; b=WB43hr/c+d+z9E1dr3O2n9Zrk01bgQhVrkcBz0BXQqEIXbQ1+GpUeBUpJF41KFf5Tf lNm4rdRmMREzcf3LvomOfI21YpbvM6rACW4qqCaREo4hE9yZVqNV07X0NRrbSwuz/Off egSFoZU1aXCiBuVzWNAUurp8glWLA6xEfQudURruUH1gBHIdxawSOyfxGL5Ck1I2okdP 1JEbf8n5QIkdeImRZLBDq54nXlEyFyEm5PgeYjggQPBUMMAaYCpvAz7nfz+b6F8205Y0 YudRzdIN6RPjy2EbEcLaYpmmMhFPTkcjZB/G7W3F9eI6T4CWb894X7wzJwyhIYdJnxcJ MAGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690446543; x=1691051343; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vqiw6r+PHEVT+EztfpBhphT+HL4dVYUe7akOolTO95E=; b=XlN9/UQ/M8ambQY9qsLMlokV3qeM+77TyK3i8U/sLtM3yxBun/Hc/YTHNAcswTdKey W0v3pXT2NT1vnJ5wuuCnJVvyUK3AtYbeVfA5F95kpi41K42YsABb8GWX06tP1ksbMMIf USR6Rr2LGK3PSjw0wIWPtPhJxIrWmMHR4S8eiTKrMJ+T9Xz3Njfn+KgjHff/zPqg6gwz kVasxIbkTNL6hWHnfD0EOtMpkgpkXr9O7Mhluepyirm5kxD/KdrEC5Ioudilx0XhICsF Zs+O6fPrx2Uft19qn49OKMbmR1YoulEQkGTKmcBa6wAG4gsM3mswEnsiRaUSv3GTzT8x 7emQ== X-Gm-Message-State: ABy/qLZKZdWPU3A+vXvcZ6vloARumjvB0ZSM1ghAgvLepjz7N3N5PHPB aAthSm2UOLWQhdOmspJRG/JxcA== X-Google-Smtp-Source: APBJJlEePlD/dAhfTCyMhSnx6fASNBNWb1h9K0gW1jyicnQaTG11W03to93lZljkXpeSk7Uf1M9P1A== X-Received: by 2002:a17:906:5356:b0:99b:d5fd:c924 with SMTP id j22-20020a170906535600b0099bd5fdc924mr1511323ejo.66.1690446542830; Thu, 27 Jul 2023 01:29:02 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id cw25-20020a170906c79900b0098d2d219649sm488322ejb.174.2023.07.27.01.29.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 01:29:02 -0700 (PDT) Message-ID: Date: Thu, 27 Jul 2023 10:29:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_kamalw@quicinc.com, jestar@qti.qualcomm.com, quic_huliu@quicinc.com References: <20230718062639.2339589-1-quic_fenglinw@quicinc.com> <20230718062639.2339589-2-quic_fenglinw@quicinc.com> <4cb9f443-bdea-695a-f1b7-3963747e9a17@quicinc.com> <5b7e624b-5d06-826d-92d1-2a721b7c83b7@quicinc.com> <4210b137-2d5d-a467-ea8c-d047701fdcc2@quicinc.com> <2fa3f27d-ff08-b923-2fb1-cf7cc888e5d5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 27/07/2023 09:54, Fenglin Wu wrote: >>>> + - enum: >>>> + - qcom,pm7550ba-vib >>>> + - const: qcom,pm7325b-vib >>>> >>> >>> Yes >> >> I wonder why this approved change turned out to something incorrect in >> your v3 patch... >> > Since I got review comments in the driver change and I was told to > refactor the driver before adding new HW support. I added the HW type > logic in the driver and I was thinking it might be good to add some > generic compatible strings to match with the HW type introduced in the > driver change. > > Anyway, I will update it to what you suggested in next patch. Drivers are not really related to bindings, so whatever HW type you add in driver, is not a reason to change bindings. Reason to change bindings could be for example: because hardware is like that. Best regards, Krzysztof