Re: [PATCH v2 1/3] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/02/2026 14:23, Rakesh Kota wrote:
> Add the compatible string "qcom,pmm8654au-pon" for the PMM8654AU PMIC.
> The PON peripheral on PMM8654AU is compatible with PMK8350, so it is
> documented as a fallback to "qcom,pmk8350-pon".

Drop everything after ,. Do not explain WHAT you did. We see it.

> 
> While PMM8654AU supports additional registers compared to the baseline,

full stop.

> there is currently no active use case for these features. This specific
> compatible string reserves the identifier for future hardware-specific
> handling if required.

All the rest is irrelevant or even wrong. We do not reserve identifiers.
If you want to reserve something, then I need to reject the patch.

> 
> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> ---

Where is the changelog? Nothing in cover letter explained what was
happening with this patch, nothing is here.

>  .../devicetree/bindings/power/reset/qcom,pon.yaml        | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> index 979a377cb4ffd577bfa51b9a3cd089acc202de0c..14b85b0d97da12c756cfe2ce33853501ba4ca46c 100644
> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> @@ -17,12 +17,16 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,pm8916-pon
> -      - qcom,pm8941-pon
> -      - qcom,pms405-pon
> -      - qcom,pm8998-pon
> -      - qcom,pmk8350-pon
> +    oneOf:
> +      - enum:
> +          - qcom,pm8916-pon
> +          - qcom,pm8941-pon
> +          - qcom,pms405-pon
> +          - qcom,pm8998-pon

Move this one up to to fix sorting while at it.

> +          - qcom,pmk8350-pon

And this above pms.

> +      - items:
> +          - const: qcom,pmm8654au-pon
> +          - const: qcom,pmk8350-pon

Best regards,
Krzysztof