From: Randy Dunlap <rdunlap@infradead.org>
To: Sean O'Brien <seobrien@chromium.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: google: add google vivaldi HID driver
Date: Mon, 17 Aug 2020 20:28:55 -0700 [thread overview]
Message-ID: <b1fcca69-8563-0a85-80e0-a955fe8bca6f@infradead.org> (raw)
In-Reply-To: <20200817194937.1.I170489c0c2ac1538b3890abb5a92b95ad4f04d01@changeid>
On 8/17/20 7:49 PM, Sean O'Brien wrote:
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 05315b434276..5676d4f521c9 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -397,6 +397,15 @@ config HID_GOOGLE_HAMMER
> help
> Say Y here if you have a Google Hammer device.
>
> +config HID_GOOGLE_VIVALDI
> + tristate "Google Vivaldi Keyboard"
> + depends on HID
> + help
> + Say Y here if you want to enable support for Google vivaldi keyboards.
Vivaldi
please.
> +
> + These are keyboards which report physical the order of consumer/action
That's an awkward sentence. -EPARSE
> + keys in the top row.
> +
help text lines (those under help) should be indented with one tab + 2 spaces
according to Documentation/process/coding-style.rst.
> config HID_GT683R
> tristate "MSI GT68xR LED support"
> depends on LEDS_CLASS && USB_HID
--
~Randy
prev parent reply other threads:[~2020-08-18 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 2:49 [PATCH] HID: google: add google vivaldi HID driver Sean O'Brien
2020-08-18 3:28 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fcca69-8563-0a85-80e0-a955fe8bca6f@infradead.org \
--to=rdunlap@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seobrien@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).