From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A2DC0015E for ; Tue, 25 Jul 2023 05:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbjGYFyF (ORCPT ); Tue, 25 Jul 2023 01:54:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232037AbjGYFxv (ORCPT ); Tue, 25 Jul 2023 01:53:51 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 556DA1BE3 for ; Mon, 24 Jul 2023 22:53:40 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b9352ff1aeso75064221fa.1 for ; Mon, 24 Jul 2023 22:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690264418; x=1690869218; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yGtjY2I6IJJ57ajiFTOVXjH7nBwULBGZDd/HJCAdG7c=; b=nPlzFgRdvGYkC6362bgv18FBpP4eBTQE/J3iNMHDYXTJ86+Gw2Af9cgcYP4zDcXKZc J0f+J5vLvxNN1uijkdROMOclFVgjcxOGOfzoiWtp64fAy3Dao6lZyMlouKjUx15aECi2 smxSI7YO0B7PcTTsVn++SYfqGPDNlc25fR1cTo9x5cpGrLiTHC3dXmdB7WGLYMscz3UL Fid0hYeZnjlcwEHRbbgMUbCiDSBefZmFNyNs7YdC0lok8dLIOq/rJOSX+JBqelILTUv4 lAxQHVTEuDtPcwFg5ZaId3BnRSenE+/7zagsArP6D+CHu22Btwf8l7ZzLkAQcNOk/ep9 Kp3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690264418; x=1690869218; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yGtjY2I6IJJ57ajiFTOVXjH7nBwULBGZDd/HJCAdG7c=; b=j+0v+VKjmv6/yQ0+XC4Zmio7/4bKe9/y+8SLopf5GGP6fBXt4Dyie4wCoPkXwE1ys4 20hNtWIFWBtx3PT7Bir9JTBmPcpEKz00BnUk57DJ+y5HwlqTqEXVkgt9F2o/21I0RSdo WiIusuT5hyBt3BotltkFwqsQTBAamETOiqkvGeE6HoSO68WmQIgoxNblIMs3YPKVJ1+m h5Y6wQTbtu7yu492jA6pkopUyIxcR9wn+m0NpPH/spdkdwYGfVGWt9aqzOBzFDXKCPmc ryro28RieMvaL03gONoq37/2MaJhJZAO42QoWHukx14uglEz66oAXZIGbYD4CVOcZU9I Q2Hg== X-Gm-Message-State: ABy/qLY4BPlMh7vjVsIDoh4taOrSSWUVsl46/tg9dgfUnhn+RhoqTDiy PT6BOVUdqVIAoEIeRyLutRgv6g== X-Google-Smtp-Source: APBJJlE6aL0qKjjw/dnLiqEek1XnS/5MAywE2WBCtv90rs+MfwAQzpO22Pb9BsLgwbwCq5d8WtP02w== X-Received: by 2002:a2e:9f09:0:b0:2b9:4ac9:6071 with SMTP id u9-20020a2e9f09000000b002b94ac96071mr7086785ljk.10.1690264418421; Mon, 24 Jul 2023 22:53:38 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id lx26-20020a170906af1a00b0099b76c3041csm5352044ejb.7.2023.07.24.22.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 22:53:27 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 07:53:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 2/3] dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, agross@kernel.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, Konrad Dybcio , Dmitry Torokhov , linux-input@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_kamalw@quicinc.com, jestar@qti.qualcomm.com References: <20230725054138.129497-1-quic_fenglinw@quicinc.com> <20230725054138.129497-3-quic_fenglinw@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230725054138.129497-3-quic_fenglinw@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 25/07/2023 07:41, Fenglin Wu wrote: > Add compatible string 'qcom,spmi-vib-gen2' for vibrator module inside > PMI632, PMI7250B, PM7325B, PM7550BA. Also, add 'qcom,spmi-vib-gen1' > string for the SPMI vibrator inside PM8916 to maintain the completeness > of the hardware version history for SPMI vibrators. > > Signed-off-by: Fenglin Wu > --- > .../bindings/input/qcom,pm8xxx-vib.yaml | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > index c8832cd0d7da..ab778714ad29 100644 > --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > @@ -11,10 +11,20 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,pm8058-vib > - - qcom,pm8916-vib > - - qcom,pm8921-vib > + oneOf: > + - enum: > + - qcom,pm8058-vib > + - qcom,pm8916-vib > + - qcom,pm8921-vib > + - qcom,spmi-vib-gen1 > + - qcom,spmi-vib-gen2 Generic compatibles should not be alone. Drop both lines. > + - items: > + - enum: > + - qcom,pmi632-vib > + - qcom,pm7250b-vib > + - qcom,pm7325b-vib > + - qcom,pm7550b-vib > + - const: qcom,spmi-vib-gen2 Best regards, Krzysztof