linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@bitmath.org>
To: Sean O'Brien <seobrien@chromium.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: marek.wyborski@emwesoft.com, linux-kernel@vger.kernel.org,
	dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
	Jiri Kosina <jikos@kernel.org>,
	claudio@ponyfleisch.ch
Subject: Re: [PATCH] [v3] HID: add support for Apple Magic Trackpad 2
Date: Sun, 30 Sep 2018 13:34:20 +0200	[thread overview]
Message-ID: <b3a3b9f8-3f74-d2d4-fb12-2cf46d756232@bitmath.org> (raw)
In-Reply-To: <CAOOzhkosyZpr+B1xwZcG3viNbWZFWr9WQtgGdP13i_+_Ocdgmg@mail.gmail.com>

Hi Sean,

> Gentle reminder, thank you!
>
> On Thu, Sep 20, 2018 at 4:13 PM Sean O'Brien <seobrien@chromium.org> wrote:
>> USB device
>>          Vendor 05ac (Apple)
>>          Device 0265 (Magic Trackpad 2)
>> Bluetooth device
>>          Vendor 004c (Apple)
>>          Device 0265 (Magic Trackpad 2)
>>
>> Add support for Apple Magic Trackpad 2 over USB and bluetooth, putting
>> the device in multi-touch mode.
>>
>> Signed-off-by: Claudio Mettler <claudio@ponyfleisch.ch>
>> Signed-off-by: Marek Wyborski <marek.wyborski@emwesoft.com>
>> Signed-off-by: Sean O'Brien <seobrien@chromium.org>
>> ---
>>
>>   drivers/hid/hid-ids.h        |   1 +
>>   drivers/hid/hid-magicmouse.c | 149 +++++++++++++++++++++++++++++++----
>>   2 files changed, 134 insertions(+), 16 deletions(-)

This version looks good.

Reviewed-by: Henrik Rydberg <rydberg@bitmath.org>

Thank you!

Henrik

  reply	other threads:[~2018-09-30 11:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 23:13 [PATCH] [v3] HID: add support for Apple Magic Trackpad 2 Sean O'Brien
2018-09-27 16:45 ` Sean O'Brien
2018-09-30 11:34   ` Henrik Rydberg [this message]
2018-10-01  8:43 ` Benjamin Tissoires
2018-10-02 22:39   ` Sean O'Brien
2018-10-03  0:04     ` Peter Hutterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3a3b9f8-3f74-d2d4-fb12-2cf46d756232@bitmath.org \
    --to=rydberg@bitmath.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=claudio@ponyfleisch.ch \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.wyborski@emwesoft.com \
    --cc=seobrien@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).