From: neil.armstrong@linaro.org
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Danila Tikhonov <danila@jiaxyga.com>
Cc: hadess@hadess.net, hdegoede@redhat.com, jeff@labundy.com,
krzk@kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@mainlining.org
Subject: Re: [PATCH] Input: goodix-berlin - Fix VDDIO regulator name according to dt-bindings
Date: Fri, 6 Sep 2024 09:59:12 +0200 [thread overview]
Message-ID: <b4573018-365f-4ce4-9452-6fc7adae3f3e@linaro.org> (raw)
In-Reply-To: <ZtqTTZizT7nAaYzq@google.com>
Hi,
On 06/09/2024 07:29, Dmitry Torokhov wrote:
> Hi Danila,
>
> On Mon, Aug 05, 2024 at 06:58:06PM +0300, Danila Tikhonov wrote:
>> The dt-bindings specify the regulator as "vddio" instead of "iovdd".
>>
>> This patch fixes the regulator name from "iovdd" to "vddio" in the
>> driver code to align with the dt-bindings. Fixing the dt-bindings
>> would break ABI, hence the fix is made in the driver instead.
>>
>> There are no users of this regulator сurrently.
>
> If there are no users (and the binding is pretty new) we should consider
> all options. Do you know the name of the supply in the datasheet?
The names comes from the downstream driver & bindings, but we don't
declare them on the Qualcomm platforms using the berlin touch ICs.
Perhaps someone from Goodix or someone with access to datasheet could confirm...
Anyway, this aligns with bindings so it's a correct patch.
Neil
>
> Thanks.
>
next prev parent reply other threads:[~2024-09-06 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 15:58 [PATCH] Input: goodix-berlin - Fix VDDIO regulator name according to dt-bindings Danila Tikhonov
2024-09-06 5:29 ` Dmitry Torokhov
2024-09-06 7:59 ` neil.armstrong [this message]
2024-09-06 7:57 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4573018-365f-4ce4-9452-6fc7adae3f3e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=danila@jiaxyga.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=jeff@labundy.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mainlining.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).