From: Colin Ian King <colin.king@canonical.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] Input: iqs5xx: Ensure error_bl is initialized on error exit path
Date: Thu, 28 Jan 2021 14:55:44 +0000 [thread overview]
Message-ID: <b5dc0706-1933-fd2b-5dfc-49fb4aed38f1@canonical.com> (raw)
In-Reply-To: <20210128143946.GA14625@labundy.com>
On 28/01/2021 14:39, Jeff LaBundy wrote:
> Hi Colin,
>
> On Thu, Jan 28, 2021 at 12:19:03PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently if the call to qs5xx_fw_file_parse fails the error return
>> exit path will read the uninitialized variable error_bl. Fix this
>> by ensuring error_bl is initialized to zero.
>>
>> Addresses-Coverity: ("Uninitialized scalar variable")
>> Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> This was fixed in [1]; it just needs pushed.
OK, thanks for letting me know.
>
> [1] https://patchwork.kernel.org/patch/12043701
>
>> ---
>> drivers/input/touchscreen/iqs5xx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c
>> index 05e0c6ff217b..54f30038dca4 100644
>> --- a/drivers/input/touchscreen/iqs5xx.c
>> +++ b/drivers/input/touchscreen/iqs5xx.c
>> @@ -852,7 +852,7 @@ static int iqs5xx_fw_file_parse(struct i2c_client *client,
>> static int iqs5xx_fw_file_write(struct i2c_client *client, const char *fw_file)
>> {
>> struct iqs5xx_private *iqs5xx = i2c_get_clientdata(client);
>> - int error, error_bl;
>> + int error, error_bl = 0;
>> u8 *pmap;
>>
>> if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE)
>> --
>> 2.29.2
>>
>
> Kind regards,
> Jeff LaBundy
>
prev parent reply other threads:[~2021-01-28 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 12:19 [PATCH][next] Input: iqs5xx: Ensure error_bl is initialized on error exit path Colin King
2021-01-28 14:39 ` Jeff LaBundy
2021-01-28 14:55 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5dc0706-1933-fd2b-5dfc-49fb4aed38f1@canonical.com \
--to=colin.king@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox