From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v5 25/36] drm/bridge: analogix_dp: Properly log AUX CH errors Date: Wed, 14 Mar 2018 12:22:24 +0530 Message-ID: References: <20180309222327.18689-1-enric.balletbo@collabora.com> <20180309222327.18689-26-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20180309222327.18689-26-enric.balletbo@collabora.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Enric Balletbo i Serra , inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, heiko@sntech.de Cc: dri-devel@lists.freedesktop.org, dianders@chromium.org, a.hajda@samsung.com, ykk@rock-chips.com, kernel@collabora.com, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, rydberg@bitmath.org, krzk@kernel.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, linux-input@vger.kernel.org, orjan.eide@arm.com, wxt@rock-chips.com, jeffy.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com, wzz@rock-chips.com, hl@rock-chips.com, jingoohan1@gmail.com, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, Laurent.pinchart@ideasonboard.com, kuankuan.y@gmail.com, hshi@chromium.org List-Id: linux-input@vger.kernel.org On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: > From: Douglas Anderson > > The code in analogix_dp_transfer() that was supposed to print out: > AUX CH error happened > > Was actually dead code. That's because the previous check (whether > the interrupt status indicated any errors) would have hit for all > errors anyway. > > Let's combine the two error checks so we can actually see AUX CH > errors. We'll also downgrade the message to a warning since some of > these types of errors might be expected for some displays. If this > gets too noisy we can downgrade again to debug. Reviewed-by: Archit Taneja Thanks, Archit > > Cc: 征增 王 > Signed-off-by: Douglas Anderson > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande > Reviewed-by: Andrzej Hajda > Signed-off-by: Enric Balletbo i Serra > Tested-by: Marek Szyprowski > --- > > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index 4eae206ec31b..58e8a28e99aa 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -1105,6 +1105,7 @@ ssize_t analogix_dp_transfer(struct analogix_dp_device *dp, > struct drm_dp_aux_msg *msg) > { > u32 reg; > + u32 status_reg; > u8 *buffer = msg->buffer; > unsigned int i; > int num_transferred = 0; > @@ -1193,16 +1194,12 @@ ssize_t analogix_dp_transfer(struct analogix_dp_device *dp, > > /* Clear interrupt source for AUX CH access error */ > reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); > - if (reg & AUX_ERR) { > + status_reg = readl(dp->reg_base + ANALOGIX_DP_AUX_CH_STA); > + if ((reg & AUX_ERR) || (status_reg & AUX_STATUS_MASK)) { > writel(AUX_ERR, dp->reg_base + ANALOGIX_DP_INT_STA); > - goto aux_error; > - } > > - /* Check AUX CH error access status */ > - reg = readl(dp->reg_base + ANALOGIX_DP_AUX_CH_STA); > - if ((reg & AUX_STATUS_MASK)) { > - dev_err(dp->dev, "AUX CH error happened: %d\n\n", > - reg & AUX_STATUS_MASK); > + dev_warn(dp->dev, "AUX CH error happened: %#x (%d)\n", > + status_reg & AUX_STATUS_MASK, !!(reg & AUX_ERR)); > goto aux_error; > } > >