linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Joe Perches <joe@perches.com>
Cc: linux-input@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v2 3/3] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()
Date: Sun, 25 Sep 2016 09:45:30 +0200	[thread overview]
Message-ID: <b735e40a-4fd2-fcc5-0c55-357ba1e4360f@users.sourceforge.net> (raw)
In-Reply-To: <1474788689.2238.3.camel@perches.com>

> This is not a good change as it messes with dmesg timestamps.

Thanks for your quick feedback.

Have you got any more concerns around multi-line text output?


> Simpler to read and more straightforward is multiple
> individual function calls.

Will it become feasible to pass the desired data also only
by one logging call directly?

Regards,
Markus

      reply	other threads:[~2016-09-25  7:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-24 13:45 [PATCH 0/4] Input-gameport: Fine-tuning for joydump_connect() SF Markus Elfring
2016-09-24 13:46 ` [PATCH 1/4] Input-gameport: Use kmalloc_array() in joydump_connect() SF Markus Elfring
2016-09-24 16:42   ` Dmitry Torokhov
2016-09-24 17:04     ` SF Markus Elfring
2016-09-24 13:47 ` [PATCH 2/4] Input-gameport: Delete an error message for a failed memory allocation SF Markus Elfring
2016-09-24 13:48 ` [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump" SF Markus Elfring
2016-09-24 16:41   ` Dmitry Torokhov
2016-09-24 16:55     ` SF Markus Elfring
2016-09-24 17:03       ` Joe Perches
2016-09-24 17:45         ` SF Markus Elfring
2016-09-24 18:01           ` Joe Perches
2016-09-24 18:45             ` SF Markus Elfring
2016-09-24 13:50 ` [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() SF Markus Elfring
2016-09-24 16:13   ` Joe Perches
2016-09-24 16:32     ` SF Markus Elfring
2016-09-24 16:39       ` Dmitry Torokhov
2016-09-24 17:20         ` SF Markus Elfring
2016-09-24 16:47       ` [PATCH 4/4] " Joe Perches
2016-09-24 19:50         ` SF Markus Elfring
2016-09-24 16:41     ` [PATCH 4/4] " SF Markus Elfring
2016-09-25  7:15     ` [PATCH v2 3/3] " SF Markus Elfring
2016-09-25  7:31       ` Joe Perches
2016-09-25  7:45         ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b735e40a-4fd2-fcc5-0c55-357ba1e4360f@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=joe@perches.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).