From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D2EDC432BE for ; Tue, 31 Aug 2021 00:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F0D460F4B for ; Tue, 31 Aug 2021 00:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239392AbhHaACh (ORCPT ); Mon, 30 Aug 2021 20:02:37 -0400 Received: from phobos.denx.de ([85.214.62.61]:35482 "EHLO phobos.denx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239185AbhHaACO (ORCPT ); Mon, 30 Aug 2021 20:02:14 -0400 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 5E81F833C5; Tue, 31 Aug 2021 02:01:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1630368078; bh=L5K3gmMa+RvboVJq51WOwQBrg9YZmJVUn/2Fh7rmmus=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GQPiR8Co+mrJvcv9lWTODl9IKjZs5qzx1mrx9hwqJQXkm+3LBvbqZIoDJy41irvI4 uUco7rddUIVUXyDPXRLEijVttiMaRmE7cxIOrrdrHa9xBmACrkPUMqDY3zBPSQ4qLi ARI1UB/W/VpaA5FONjibz5tWiz8PdYF+xRvNsmMXwIw/waWEqbbwYakEA+CaNELSvX ccfl+A5V9XOaWhDS4tGPVVAYh/K5mBS4RsnOZeKcF3yhzeqBpB/JDHR/c3B4tCuqyS y8OvlNY9O7imRy9Opxvd9bn13odC36kN8UshorMxuwAsxMIKvxPZLzLcZXLOzMUWh7 O9IzATxfRksKQ== Subject: Re: [PATCH v2 1/3] Input: ili210x - use resolution from ili251x firmware To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, ch@denx.de, Joe Hung , Luca Hsu References: <20210827211258.318618-1-marex@denx.de> <3c4be28d-e749-d63a-37c5-60ff686dc6dc@denx.de> From: Marek Vasut Message-ID: Date: Tue, 31 Aug 2021 02:01:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 8/31/21 1:46 AM, Dmitry Torokhov wrote: > On Tue, Aug 31, 2021 at 01:31:06AM +0200, Marek Vasut wrote: >> On 8/31/21 1:21 AM, Dmitry Torokhov wrote: >>> On Tue, Aug 31, 2021 at 12:49:49AM +0200, Marek Vasut wrote: >>>> On 8/30/21 10:55 PM, Dmitry Torokhov wrote: >>>> >>>> [...] >>>> >>>>>> + return -EINVAL; >>>>>> + >>>>>> + priv->input->absinfo[ABS_X].maximum = resx - 1; >>>>>> + priv->input->absinfo[ABS_Y].maximum = resy - 1; >>>>>> + priv->input->absinfo[ABS_MT_POSITION_X].maximum = resx - 1; >>>>>> + priv->input->absinfo[ABS_MT_POSITION_Y].maximum = resy - 1; >>>>> >>>>> There is >>>>> >>>>> input_set_abs_max(priv->input, ABS_X, resx - 1); >>>> >>>> git grep finds nothing in linux-next / your tree on k.org / patchwork. Where >>>> is that ? >>> >>> Look for INPUT_GENERATE_ABS_ACCESSORS in include/linux/input.h >> >> Oh, input_abs_set_max, thanks. > > Ah, sorry, mistyped the name first time around. Yep, no worries, this will be fixed in V3.