linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Nate Yocom <nate@yocom.org>,
	dmitry.torokhov@gmail.com,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] Input: joystick: xpad: Add X-Box Adaptive Controller Layer button
Date: Wed, 24 Aug 2022 17:36:30 +0200	[thread overview]
Message-ID: <ba73ce3733ff76b081fb0916e4b9be82179a42dc.camel@hadess.net> (raw)
In-Reply-To: <b32cee349fdfa6ffdc60cd31f662dbd479b01e4d.camel@hadess.net>

On Wed, 2022-08-17 at 12:37 +0200, Bastien Nocera wrote:
> On Sat, 2022-08-13 at 11:53 -0700, Nate Yocom wrote:
> > Adds a new quirk for controllers that have a Layer button which has
> > 4
> > states, reflected as an ABS_MISC axis with 4 values.
> 
> It's called the "Profile Button" in the official documentation:
> https://support.xbox.com/en-US/help/account-profile/accessibility/get-to-know-adaptive-controller
> so best to call it that.
> 
> I wonder we have any other examples of profile handling in input
> drivers. The xpadneo driver implements the profiles in the kernel
> driver directly.
> 
> Benjamin?

After speaking to Benjamin, it was clear that ABS_MISC wasn't the right
absolute axis to use.

I think that adding a new ABS_* axes in include/uapi/linux/input-event-
codes.h would be the best, for example ABS_PROFILE as 0x21.

Dmitry, what do you think?

The idea here is to encode a hardware controlled switch that has 4
possible values. Its state will be sent with every input event in order
for user-space to (maybe) apply a specific profile to the events.

This would also be used by the XBox Elite 2 controller driver.

Cheers

  parent reply	other threads:[~2022-08-24 15:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-13 18:53 [PATCH v3 0/3] Input: joystick: xpad: Add X-Box Adaptive Controller support Nate Yocom
2022-08-13 18:53 ` [PATCH v3 1/3] " Nate Yocom
2022-08-17 10:37   ` Bastien Nocera
2022-08-17 17:36     ` Nate Yocom
2022-08-13 18:53 ` [PATCH v3 2/3] Input: joystick: xpad: Add X-Box Adaptive Controller Layer button Nate Yocom
2022-08-17 10:37   ` Bastien Nocera
2022-08-17 17:42     ` Nate Yocom
2022-08-24 15:36     ` Bastien Nocera [this message]
2022-08-25 22:21       ` Nate Yocom
2022-08-13 18:53 ` [PATCH v3 3/3] Input: joystick: xpad: Add X-Box Adaptive Controller XBox button Nate Yocom
2022-08-17 10:37   ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba73ce3733ff76b081fb0916e4b9be82179a42dc.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nate@yocom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).