From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A939C001DE for ; Tue, 15 Aug 2023 05:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234568AbjHOFJE (ORCPT ); Tue, 15 Aug 2023 01:09:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234598AbjHOFId (ORCPT ); Tue, 15 Aug 2023 01:08:33 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38343171B for ; Mon, 14 Aug 2023 22:08:27 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99bf8e5ab39so684540566b.2 for ; Mon, 14 Aug 2023 22:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692076106; x=1692680906; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/RtZ3qk8KDKAyM7uZ723VgsO7ZDljAE8bUmfZOovcVo=; b=sTZl+F97t7YyvAewnlM00xqrYjUFSyHwBOdsZ9fZeLUUSF0ZbNjPiebYsCeXNOux5L Om0GcWypAhk/8WoE3iP5TCdCujKevLy/0tw/nHuWkNCBZRs3la0CT1cxH9wyhfsAx4f0 lcCHRRtXl5rj+3oq8hMMxDMK30KAxWoSaQW+QntiRB3+839SOSY8LtnCGqL7o2OQc4Gw NTwf3aJg1nhDJ3jSNY0ylXCTsG6xCCcvfgmBdKk9iwFEO0JS0gmfwxPFqg0YwCRmTcKe H53CJMmuTAgGGGw7MN36x3QKlDJ8RROukHZNovnd04tkhYkR4FicRyzRG0IThK/qdAvc WTWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692076106; x=1692680906; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/RtZ3qk8KDKAyM7uZ723VgsO7ZDljAE8bUmfZOovcVo=; b=gGd/k6Ed3npBu6a0LTsEEdzN9AdcDu33OruFckF3OU30ezbzwIpdSfdBYTS/n+5fA2 MWESiwPI+3Mq0EGC5Dd6irh/mL5U/8pFKtv+xa9An6ErYXANCM5LR98uBadQxMAyYpNB 9Kv+dwjzuVKtGFquqlm2MgR7o16bbQFpfEN/SdvGxsdQVC/r6knzy6TqNmrym1sifPmP OgZj3Jla9U9R7Fy1+KyiEqrR/CuA4INhv5CFsI1Ub1FFs9bi8WwMTFHGDFkPNED5FfUZ vs/GUObf1HafMIvgPiA++Cltf5oZawasiPFgNSmb3XVEJaeflaBjKcHWkbui66U+d2Yn BXCA== X-Gm-Message-State: AOJu0YzNywyX+A5EnPsVw5RqvAOxUflrZ9oZk7M8ArHXgjwIkXgnEG4v PnU9rtyP2R3+gYOg+/rtGtfpsw== X-Google-Smtp-Source: AGHT+IEHl+XQA70lMQvfpN0fpkw+dM2wsdNQNUQCh6s7LR/jIakD6PWpTcV4OEOZuywWquixGwOmGg== X-Received: by 2002:a17:907:2c74:b0:99d:b9d6:6011 with SMTP id ib20-20020a1709072c7400b0099db9d66011mr2031715ejc.55.1692076106060; Mon, 14 Aug 2023 22:08:26 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id mb25-20020a170906eb1900b0099ce025f8ccsm6514364ejb.186.2023.08.14.22.08.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 22:08:25 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 07:08:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/2] Input: cs40l50 - Initial support for Cirrus Logic CS40L50 Content-Language: en-US To: James Ogletree Cc: Dmitry Torokhov , Fred Treven , Ben Bright , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Peng Fan , Jean Delvare , Jeff LaBundy , Randy Dunlap , Arnd Bergmann , Eddie James , Jacky Bai , Markus Schneider-Pargmann , ChiYuan Huang , Jerome Neanne , "patches@cirrus.com" , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230808172511.665787-1-james.ogletree@cirrus.com> <20230808172511.665787-2-james.ogletree@cirrus.com> <065fbe51-928c-4728-efc2-bde87cd48cb3@linaro.org> <3f406442-d46e-7f9e-426d-22a96f893103@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 14/08/2023 23:44, James Ogletree wrote: >>>> I don't think this is a module. >>> >>> It can be compiled as a module with CONFIG_INPUT_CS40L50=m. However, there is a >>> typo in the Kconfig entry description: the module will be called “cs40l50” not “cs40l50-core”. >>> That will be fixed. >> >> Really, *this* unit file can be compiled as module? Where is the >> module_xxx_driver() then? >> > > As I understand it, the “module_XXX_driver()” has nothing to do with whether or not the file is built as a module, rather it just provides code to attach the driver to a bus. But this is a bus-agnostic, separate module (not a driver in itself) that provides implementation to cs40l26-i2c or cs40l26-spi drivers, which do contain that macro as they should. This doesn’t appear to be an uncommon pattern. I see now in the Makefile that it can be indeed built as module and compiled on its own. It's fine then. Best regards, Krzysztof