From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] Input: libps2 - mark expected switch fall-through Date: Tue, 7 May 2019 16:37:27 -0500 Message-ID: References: <20190507182409.GA11027@embeddedor> <20190507192744.GA248929@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190507192744.GA248929@dtor-ws> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook List-Id: linux-input@vger.kernel.org On 5/7/19 2:27 PM, Dmitry Torokhov wrote: > On Tue, May 07, 2019 at 01:24:09PM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’: >> drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if (ps2dev->flags & PS2_FLAG_NAK) { >> ^ >> drivers/input/serio/libps2.c:417:2: note: here >> case 0x00: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva > > Applied, thank you. > Awesome. :) Thanks, Dmitry. -- Gustavo