Re: [PATCH] new driver for wireless xbox receiver for review

["Brian Magnuson" <bdmagnuson@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2559 bytes --]

Hi Dmitry, (sorry about the misspelling last time)

On 5/30/07, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> Hi Brain,
>
> [Added Jan to CC list]
>
> On 5/29/07, Brian Magnuson <bdmagnuson@gmail.com> wrote:
> > Hi Dimitri,
> >
> > Thanks for taking the time to review.  My reponses are inline.
> >
> > -Brian
> >
> > * Dmitry Torokhov <dmitry.torokhov@gmail.com> [2007-05-29 20:03]:
> > >
> > > Thnk you for the patch. Looking at the code I do not see one device
> > > supporintg multiple controllers... You have one input device per usb
> > > device/interface and the properties of said device are known
> > > beforehand. So I would just create and register input device right
> > > there in xboxrcvr_probe() and get rid of your build and teardown
> > > works. The fact that is it a wireless device and at transmitter may at
> > > times be out of range is not important.
> >
> > Actually, I rather liked the fact that the input devices only show up
> when
> > there is a controller connected to the receiver, since there can be
> anywhere
> > from 0-4 controllers alive.  This way there are no device nodes for
> > non-existant controllers.
>
> Let's keep it simple. This way we don't have to worry about races
> between build and teardown work pieces and the driver is much
> simplier. After all we don't do dynamic device creation for wireless
> mice (non blue-tooth). And if we did it would make some programs
> unhappy if they did not see that device all the time... Even with
> controller - imagine you are playing and somebody calls you - you walk
> away with your controller in hand and when you come back it stops
> working because we tore down one device and created the a one but
> application is still latched to the old device - not nice.


Yeah, I came to the same conclusion shortly after sending my last message.
I'll change it to just create all 4 devices in probe.  I was going to do the
"disconnect + reconnect and see if it still works" test when I got home
today.
I don't expect it to.

> >
> > > Overall I would like support for this wireless receiver to be
> > > incorporated into xpad.c driver.
> >
> > Knew that was coming :).  Should be able to manage it.  Since the
> wireless
> > model returns a expanded data format it needs to be handled specially.
> > Another flag in the xpad_device struct?
>
> We have xtype field, I think it should be used.


I don't see this field in xpad_device in your tree or Linus'.

In any case I'll take these changes and your earlier ones, merge it into
xpad.c and
resubmit.

Thanks,
Brian

[-- Attachment #2: Type: text/html, Size: 3393 bytes --]