linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry <dbaryshkov@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH][RESEND] gpio-keys debouncing support
Date: Wed, 7 May 2008 20:21:27 +0400	[thread overview]
Message-ID: <bc64b4640805070921o2f036252m9c03b830a1b1e759@mail.gmail.com> (raw)
In-Reply-To: <20080506095530.ZZRA012@mailhub.coreip.homeip.net>

Hi, Dmitry,

2008/5/6, Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> Hi Dmitry,
>
>
>  On Fri, May 02, 2008 at 03:20:48PM +0400, Dmitry Baryshkov wrote:
>  > Sometimes gpio line can generate jitter while transitioning from one state
>  > to another one. Implement a way to filter such noise during transitions.
>  >
>
>
> I don't think we need to do both count and interval and you don't
>  really need to track state... What do you think about the patch below?

I would say it's pretty different from what I meant. You patch only
delays the decision about the status of the pin while mine does really
"average" the status
of the pin. E.g. in my tosa PDA the headphones jack is a bit noisy. So
the input layer shouldn't react to the noise. And with your patch each
time the GPIO irq is generated the input layer will get input_sync.

-- 
With best wishes
Dmitry

  reply	other threads:[~2008-05-07 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-02 11:20 [PATCH][RESEND] gpio-keys debouncing support Dmitry Baryshkov
2008-05-06 13:57 ` Dmitry Torokhov
2008-05-07 16:21   ` Dmitry [this message]
2008-05-07 17:20     ` Dmitry Torokhov
2008-05-07 19:06       ` Dmitry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc64b4640805070921o2f036252m9c03b830a1b1e759@mail.gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).