From: Dmitry <dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ivo van Doorn <ivdoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] RFKILL: fix input layer initialisation
Date: Tue, 28 Oct 2008 15:33:49 +0300 [thread overview]
Message-ID: <bc64b4640810280533x445e7869m444dac909f8be1d2@mail.gmail.com> (raw)
In-Reply-To: <200810221905.58169.IvDoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008/10/22 Ivo van Doorn <ivdoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> On Wednesday 22 October 2008, Dmitry Baryshkov wrote:
>> Initialise correctly last fields, so tasks can be actually executed.
>> On some architectures the initial jiffies value is not zero, so later
>> all rfkill incorrectly decides that rfkill_*.last is in future.
>>
>> Signed-off-by: Dmitry Baryshkov <dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> net/rfkill/rfkill-input.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/net/rfkill/rfkill-input.c b/net/rfkill/rfkill-input.c
>> index e5b6955..cd93f48 100644
>> --- a/net/rfkill/rfkill-input.c
>> +++ b/net/rfkill/rfkill-input.c
>> @@ -255,6 +255,11 @@ static struct input_handler rfkill_handler = {
>>
>> static int __init rfkill_handler_init(void)
>> {
>> + unsigned long last_run = jiffies - msecs_to_jiffies(500);
>> + rfkill_wlan.last = last_run;
>> + rfkill_bt.last = last_run;
>> + rfkill_uwb.last = last_run;
>> + rfkill_wimax.last = last_run;
>> return input_register_handler(&rfkill_handler);
>> }
>
> I believe Dmitry Torokhov recently moved the rfkill structures for wlan, bt, etc
> into an array which allowed for easy looping through all structures. That would
> make updating all entries easier (and less prone to errors when a new structure
> is added).
I can't find the patch in question. Could you please point me to it?
>
> Could you rebase thise patch on top of that one?
> Thanks,
--
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-28 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 16:52 [PATCH] RFKILL: fix input layer initialisation Dmitry Baryshkov
2008-10-22 17:05 ` Ivo van Doorn
[not found] ` <200810221905.58169.IvDoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-10-28 12:33 ` Dmitry [this message]
2008-10-22 17:15 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc64b4640810280533x445e7869m444dac909f8be1d2@mail.gmail.com \
--to=dbaryshkov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=ivdoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).