Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

[Bagas Sanjaya]

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> On a kernel 6.4.5 and less, the keyboard is working fine.
> 
> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.
> 
> [    0.668850] input: ASUE140D:00 04F3:31B9 Keyboard as /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/input/input5
> ...
> [    1.930328] input: ASUE140D:00 04F3:31B9 Keyboard as /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/input/input13

See Bugzilla for the full thread.

Anyway, I'm adding this regression to regzbot:

#regzbot introduced: v6.4..v6.5-rc1 https://bugzilla.kernel.org/show_bug.cgi?id=217726
#regzbot title: ASUE140D:00 04F3:31B9 doesn't respond to input

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217726

-- 
An old man doll... just what I always wanted! - Clara

Re: Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

[Linux regression tracking (Thorsten Leemhuis)]

Lo!

On 30.07.23 04:41, Bagas Sanjaya wrote:
> 
> I notice a regression report on Bugzilla [1]. Quoting from it:
> 
>> On a kernel 6.4.5 and less, the keyboard is working fine.
>>
>> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.

That is a AMD Ryzen Laptop. And if that really started from
v6.4.6..v6.4.7 then I guess there is a decent chance that this is caused
by ```ACPI: resource: Remove "Zen" specific match and quirks``` from
Mario. Hence adding him to the list of recipients.

Guilhem Lettron: if you have a minute, could you try if reverting that
patch ontop of 6.4.7 fixes things?

Ciao, Thorsten

>> [    0.668850] input: ASUE140D:00 04F3:31B9 Keyboard as /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/input/input5
>> ...
>> [    1.930328] input: ASUE140D:00 04F3:31B9 Keyboard as /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/input/input13
> 
> See Bugzilla for the full thread.
> 
> Anyway, I'm adding this regression to regzbot:
> 
> #regzbot introduced: v6.4..v6.5-rc1 https://bugzilla.kernel.org/show_bug.cgi?id=217726
> #regzbot title: ASUE140D:00 04F3:31B9 doesn't respond to input
> 
> Thanks.
> 
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217726

Re: Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

[Mario Limonciello]

On 7/29/23 23:49, Linux regression tracking (Thorsten Leemhuis) wrote:
> Lo!
> 
> On 30.07.23 04:41, Bagas Sanjaya wrote:
>>
>> I notice a regression report on Bugzilla [1]. Quoting from it:
>>
>>> On a kernel 6.4.5 and less, the keyboard is working fine.
>>>
>>> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.
> 
> That is a AMD Ryzen Laptop. And if that really started from
> v6.4.6..v6.4.7 then I guess there is a decent chance that this is caused
> by ```ACPI: resource: Remove "Zen" specific match and quirks``` from
> Mario. Hence adding him to the list of recipients.
> 
> Guilhem Lettron: if you have a minute, could you try if reverting that
> patch ontop of 6.4.7 fixes things?
> 

That looks the most likely to me too.
If it helps, I would like the artifacts I requested added to the kernel 
bugzilla.

> Ciao, Thorsten
> 
>>> [    0.668850] input: ASUE140D:00 04F3:31B9 Keyboard as /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/input/input5
>>> ...
>>> [    1.930328] input: ASUE140D:00 04F3:31B9 Keyboard as /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/input/input13
>>
>> See Bugzilla for the full thread.
>>
>> Anyway, I'm adding this regression to regzbot:
>>
>> #regzbot introduced: v6.4..v6.5-rc1 https://bugzilla.kernel.org/show_bug.cgi?id=217726
>> #regzbot title: ASUE140D:00 04F3:31B9 doesn't respond to input
>>
>> Thanks.
>>
>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217726
> 

Re: Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

[August Wikerfors]

On 2023-07-30 06:49, Linux regression tracking (Thorsten Leemhuis) wrote:
> Lo!
> 
> On 30.07.23 04:41, Bagas Sanjaya wrote:
>>
>> I notice a regression report on Bugzilla [1]. Quoting from it:
>>
>>> On a kernel 6.4.5 and less, the keyboard is working fine.
>>>
>>> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.
> 
> That is a AMD Ryzen Laptop. And if that really started from
> v6.4.6..v6.4.7 then I guess there is a decent chance that this is caused
> by ```ACPI: resource: Remove "Zen" specific match and quirks``` from
> Mario. Hence adding him to the list of recipients.

Confirmed now, see https://bugzilla.kernel.org/show_bug.cgi?id=217726#c9

#regzbot introduced: a9c4a912b7dc7ff922d4b9261160c001558f9755

Re: Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

[Hans de Goede]

Hi,

On 8/4/23 17:26, August Wikerfors wrote:
> On 2023-07-30 06:49, Linux regression tracking (Thorsten Leemhuis) wrote:
>> Lo!
>>
>> On 30.07.23 04:41, Bagas Sanjaya wrote:
>>>
>>> I notice a regression report on Bugzilla [1]. Quoting from it:
>>>
>>>> On a kernel 6.4.5 and less, the keyboard is working fine.
>>>>
>>>> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.
>>
>> That is a AMD Ryzen Laptop. And if that really started from
>> v6.4.6..v6.4.7 then I guess there is a decent chance that this is caused
>> by ```ACPI: resource: Remove "Zen" specific match and quirks``` from
>> Mario. Hence adding him to the list of recipients.
> 
> Confirmed now, see https://bugzilla.kernel.org/show_bug.cgi?id=217726#c9
> 
> #regzbot introduced: a9c4a912b7dc7ff922d4b9261160c001558f9755

We just have received 2 bug reports for Fedora which I believe are also
this issue (not confirmed yet):

https://bugzilla.redhat.com/show_bug.cgi?id=2229165
https://bugzilla.redhat.com/show_bug.cgi?id=2229317

I'm going to create a Fedora 6.4.y test-kernel with a9c4a912b7dc7ff
reverted.

IMHO we really should revert a9c4a912b7dc7ff upstream,
at least for the 6.4.y series where it seems to be doing
more harm then good.

And propably also for 6.5-rc# for now until we figure out
a better solution.

Regards,

Hans

Re: Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

[Linux regression tracking (Thorsten Leemhuis)]

On 05.08.23 15:09, Hans de Goede wrote:
> On 8/4/23 17:26, August Wikerfors wrote:
>> On 2023-07-30 06:49, Linux regression tracking (Thorsten Leemhuis) wrote:
>>> Lo!
>>>
>>> On 30.07.23 04:41, Bagas Sanjaya wrote:
>>>>
>>>> I notice a regression report on Bugzilla [1]. Quoting from it:
>>>>
>>>>> On a kernel 6.4.5 and less, the keyboard is working fine.
>>>>>
>>>>> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.
>>>
>>> That is a AMD Ryzen Laptop. And if that really started from
>>> v6.4.6..v6.4.7 then I guess there is a decent chance that this is caused
>>> by ```ACPI: resource: Remove "Zen" specific match and quirks``` from
>>> Mario. Hence adding him to the list of recipients.
>>
>> Confirmed now, see https://bugzilla.kernel.org/show_bug.cgi?id=217726#c9
>>
>> #regzbot introduced: a9c4a912b7dc7ff922d4b9261160c001558f9755
> 
> We just have received 2 bug reports for Fedora which I believe are also
> this issue (not confirmed yet):
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2229165
> https://bugzilla.redhat.com/show_bug.cgi?id=2229317

Interesting, thx for sharing! I just asked people there to share
dmidecode and acpidump to check if those are different machines.

> I'm going to create a Fedora 6.4.y test-kernel with a9c4a912b7dc7ff
> reverted.
> 
> IMHO we really should revert a9c4a912b7dc7ff upstream,
> at least for the 6.4.y series

That is unlikely to be a option, because as explained in
Documentation/process/handling-regressions.rst Greg's stance in cases
like this usually is "fix it in mainline, and then I'll pick up the fix".

> where it seems to be doing more harm then good.
> 
> And propably also for 6.5-rc# for now until we figure out
> a better solution.

Hmmm, looks like the issue and the fix for one of the machines[1] didn't
make much progress this week, so I tend to agree. Mario?

[1]
https://lore.kernel.org/all/20230728191408.18141-1-mario.limonciello@amd.com/

Ciao, Thorsten

Re: Fwd: 6.5 - 6.4.7 Regression : ASUS UM5302TA Keyboard don't work

[Hans de Goede]

Hi,

On 8/5/23 15:09, Hans de Goede wrote:
> Hi,
> 
> On 8/4/23 17:26, August Wikerfors wrote:
>> On 2023-07-30 06:49, Linux regression tracking (Thorsten Leemhuis) wrote:
>>> Lo!
>>>
>>> On 30.07.23 04:41, Bagas Sanjaya wrote:
>>>>
>>>> I notice a regression report on Bugzilla [1]. Quoting from it:
>>>>
>>>>> On a kernel 6.4.5 and less, the keyboard is working fine.
>>>>>
>>>>> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.
>>>
>>> That is a AMD Ryzen Laptop. And if that really started from
>>> v6.4.6..v6.4.7 then I guess there is a decent chance that this is caused
>>> by ```ACPI: resource: Remove "Zen" specific match and quirks``` from
>>> Mario. Hence adding him to the list of recipients.
>>
>> Confirmed now, see https://bugzilla.kernel.org/show_bug.cgi?id=217726#c9
>>
>> #regzbot introduced: a9c4a912b7dc7ff922d4b9261160c001558f9755
> 
> We just have received 2 bug reports for Fedora which I believe are also
> this issue (not confirmed yet):
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2229165
> https://bugzilla.redhat.com/show_bug.cgi?id=2229317
> 
> I'm going to create a Fedora 6.4.y test-kernel with a9c4a912b7dc7ff
> reverted.
> 
> IMHO we really should revert a9c4a912b7dc7ff upstream,
> at least for the 6.4.y series where it seems to be doing
> more harm then good.
> 
> And propably also for 6.5-rc# for now until we figure out
> a better solution.

Testing has shown that reverting also fixes the 2 Fedora bugs.

I have submitted a revert of a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks") upstream now, because I believe that that is the best way to fix the regressions caused by this (until we figure out a better way to deal with the kbd interrupt trigger-type issues):

https://lore.kernel.org/linux-acpi/20230806151453.10690-1-hdegoede@redhat.com/

Regards,

Hans