From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 738DBC433EF for ; Tue, 12 Apr 2022 11:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234450AbiDLLk6 (ORCPT ); Tue, 12 Apr 2022 07:40:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356155AbiDLLjt (ORCPT ); Tue, 12 Apr 2022 07:39:49 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04EAB5AA5F; Tue, 12 Apr 2022 03:20:37 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0FFED3201F82; Tue, 12 Apr 2022 06:20:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 12 Apr 2022 06:20:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undef.tools; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1649758833; x= 1649845233; bh=aRTApUSPxPOLZop5S/TZELqtxAg3W/UHUjXVwD/lHLM=; b=R R5rYINfZ0nps4BJkw16j8qEW+Mrpac5C0AcE8g6ztszRuzlpkf6xRrKhuNXdCr9l dX+cGVE4H+Dz6kWo68cr8+qWx01qjMI0j/VldYYQTKaN6WnHNLqel7VFf27FPVyX AGJY2ipZYg7OJF5UkLWjqUBlDRDq6oo7MfOx0SUzIrPKhGaUAE3Wfo4GaWIF/SWZ sTHhBFR5c4zhyaoXwAXvZpp6Odkj6zw7YDeBWGRxLER8xmATblZdsJsbYfhkRKSF Ou5J8sVVd8Al9xAC2CFJt9aJeyGV0L/HyKmHDqE/9+pS0OSRQq+cA+1WJQpJ1Q19 9PPbsjbuKKt+F1j2Oi/WQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1649758833; x=1649845233; bh=aRTApUSPxPOLZ op5S/TZELqtxAg3W/UHUjXVwD/lHLM=; b=afgmwmEBa0E/skokOknejBLFq8PoO u7YabiKT6Ox7ixA/5ot9FX7wsZ1+oS4wYTSiGGg5TitU0SR9ZFg6ZVdL0Ipq5nV1 DknfCz/WUcpytUgh4SFb8kBjDGeqr+F0LFLsYhEiTEJRx7pw7LrnqSGxB/s3na5w o3pn9ufAC/s83FdMlkWgxGYnIUVTu5QR+QNnPCCcbJlraV7vFOJDQi4IbO21yZUS itd5F3kYF3PFYf09pvOMCePoQ/ZVZ7QDg/KyZSjuE7B+GV1U1OMzz7wGU3tB6lod jcATYcA7NSo5pKYhI4FeFpI8KkKB7/zUproAdjq7nBGaqDKkv89wGrgEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekkedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfgrrhhr rghhuceokhgvrhhnvghlsehunhguvghfrdhtohholhhsqeenucggtffrrghtthgvrhhnpe dvveekhffgtdduveekgeefiefguedujefhudfhvdfhffehffdtgfdutdetjeevffenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkvghrnhgvlh esuhhnuggvfhdrthhoohhlsh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Apr 2022 06:20:29 -0400 (EDT) Message-ID: Date: Tue, 12 Apr 2022 20:20:24 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/5] Input: pinephone-keyboard - Build in the default keymap Content-Language: en-US To: Samuel Holland , Dmitry Torokhov , linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, Wolfram Sang , Ondrej Jirman References: <20220129230043.12422-1-samuel@sholland.org> <20220129230043.12422-4-samuel@sholland.org> From: Jarrah In-Reply-To: <20220129230043.12422-4-samuel@sholland.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 1/30/22 10:00, Samuel Holland wrote: > + > +static const uint32_t ppkb_default_fn_keymap[] = { > + KEY(0, 0, KEY_FN_ESC), > + KEY(0, 1, KEY_F1), > + KEY(0, 2, KEY_F2), > + KEY(0, 3, KEY_F3), > + KEY(0, 4, KEY_F4), > + KEY(0, 5, KEY_F5), > + KEY(0, 6, KEY_F6), > + KEY(0, 7, KEY_F7), > + KEY(0, 8, KEY_F8), > + KEY(0, 9, KEY_F9), > + KEY(0, 10, KEY_F10), > + KEY(0, 11, KEY_DELETE), > + > + KEY(2, 0, KEY_SYSRQ), > + KEY(2, 10, KEY_INSERT), > + The driver currently being patched into most distros supporting the keyboard exposes the symbols printed on the keyboard rather than the F* keys on the function layer. While I agree than exposing function keys on the Fn layer is more logical, in practice running this patch for a day I've found it's far more useful to have quick access to the standard set of symbols (such as | and -) than to have the function keys. Would it be possible to either set the default back to symbols or expose another layer (potentially under the "pine" key)? An alternative solution proposed on the Mobian issue for this was to add a module option, allowing these to be switched at runtime rather than compile time.