Linux Input/HID development
 help / color / mirror / Atom feed
From: Seth Miller <miller.seth@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] HID: Ignore battery for Elan touchscreen on ASUS UX550
Date: Fri, 08 Jan 2021 09:41:56 -0600	[thread overview]
Message-ID: <be49cd57e53368062a5de07dcb7af2da0954771d.camel@gmail.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2101081552560.13752@cbobk.fhfr.pm>

On Fri, 2021-01-08 at 15:53 +0100, Jiri Kosina wrote:
> On Mon, 4 Jan 2021, Seth Miller wrote:
> 
> > Battery status is being reported for the Elan touchscreen on ASUS
> > UX550 laptops despite not having a batter. It always shows either 0
> > or
> > 1%.
> > 
> > Signed-off-by: Seth Miller <miller.seth@gmail.com>
> 
> Seth, thanks for the patch. It has, however, been line-wrapped by
> your 
> mail client, so I can't apply it as-is. Could you please fix that up
> and 
> resend?
> 
> Thanks,
> 

Jiri,
My apologies for the formatting issues. I wasn't aware Gmail's client silently inserted line breaks in plain text emails. Hopefully Evolution can do a bit better.

Signed-off-by: Seth Miller <miller.seth@gmail.com>

---
 drivers/hid/hid-ids.h   | 1 +
 drivers/hid/hid-input.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f170feaac40b..94180c63571e 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -387,6 +387,7 @@
 #define USB_DEVICE_ID_TOSHIBA_CLICK_L9W	0x0401
 #define USB_DEVICE_ID_HP_X2		0x074d
 #define USB_DEVICE_ID_HP_X2_10_COVER	0x0755
+#define USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN	0x2706
 
 #define USB_VENDOR_ID_ELECOM		0x056e
 #define USB_DEVICE_ID_ELECOM_BM084	0x0061
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 4dca11392459..32024905fd70 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -322,6 +322,8 @@ static const struct hid_device_id hid_battery_quirks[] = {
 	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH,
 		USB_DEVICE_ID_LOGITECH_DINOVO_EDGE_KBD),
 	  HID_BATTERY_QUIRK_IGNORE },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN),
+	  HID_BATTERY_QUIRK_IGNORE },
 	{}
 };
 
-- 
2.29.2


  reply	other threads:[~2021-01-08 15:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  4:58 [PATCH] HID: Ignore battery for Elan touchscreen on ASUS UX550 Seth Miller
2021-01-08 14:53 ` Jiri Kosina
2021-01-08 15:41   ` Seth Miller [this message]
2021-01-08 15:53     ` Jiri Kosina
2021-01-08 17:13       ` Seth Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be49cd57e53368062a5de07dcb7af2da0954771d.camel@gmail.com \
    --to=miller.seth@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox