From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFCFC4338F for ; Fri, 23 Jul 2021 19:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CBD160D07 for ; Fri, 23 Jul 2021 19:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbhGWSam (ORCPT ); Fri, 23 Jul 2021 14:30:42 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:44983 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbhGWSam (ORCPT ); Fri, 23 Jul 2021 14:30:42 -0400 Received: (Authenticated sender: hadess@hadess.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 39DFE40002; Fri, 23 Jul 2021 19:11:11 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices From: Bastien Nocera To: Hamza Mahfooz , linux-kernel@vger.kernel.org Cc: Filipe =?ISO-8859-1?Q?La=EDns?= , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Date: Fri, 23 Jul 2021 21:11:11 +0200 In-Reply-To: <20210723185720.29314-1-someguy@effective-light.com> References: <20210723185720.29314-1-someguy@effective-light.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.2 (3.40.2-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, 2021-07-23 at 14:57 -0400, Hamza Mahfooz wrote: > For devices that only support the BATTERY_VOLTAGE (0x1001) feature, > UPower > requires the additional information provided by this patch, to set > them up. > > Signed-off-by: Hamza Mahfooz > --- > > v2: use ARRAY_SIZE() and set voltages[]'s size to 100 > > v3: add a check to ensure that exactly 100 elements are in voltages[] > --- > > +       BUILD_BUG_ON(ARRAY_SIZE(voltages) != 100); Sweet! Reviewed-By: Bastien Nocera