linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zack Rusin <zackr@vmware.com>
To: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	Pv-drivers <Pv-drivers@vmware.com>,
	"zhouzongmin@kylinos.cn" <zhouzongmin@kylinos.cn>,
	Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] Input: vmmouse - add macros to enable vmmouse relative mode
Date: Fri, 28 Apr 2023 03:35:20 +0000	[thread overview]
Message-ID: <c0a986aaf5acf10af3a6a3a0220791d18d18df0e.camel@vmware.com> (raw)
In-Reply-To: <9d739de8fec7683c3a71bc1be3229818325ade0b.camel@kylinos.cn>

On Fri, 2023-04-28 at 10:34 +0800, zongmin zhou wrote:
> On Thu, 2023-04-20 at 09:49 +0800, 周宗敏 wrote:
> > > Dear zack:
> > >
> > > As far as I know, I think in the current design for vmmouse device,
> > > the mouse mode can only choose one,can't request both two mode.
> > >
> > > The flowchart for vmmouse device between host and guest roughly as
> > > > follows:
> picture link:
> https://imgs.wiki/imgs/2023/04/28/1898b0428ecb366a.png
>
> > > QEMU VMMouse emulation code defined variables of 's->absolute'
> > > to identify the mouse mode requested by the guest driver.
> > > Based on the value of 's->absolute',qemu will add different >
> > > spice-input VD-Interface,
> > > spice-server will notify client to use the correct mouse mode,
> > > and then spice client will update mouse motion/position based on
> > > the > mouse mode.
> > >
> > > About the VMMOUSE_RELATIVE_PACKET events,I guess that designer may
> > > > want use it
> > > to distinguish relative from absolute of the process events.But >
> > > doesn't mark them as such
> > > on QEMU's vmmouse device code.In fact, the status corresponds to
> > > the > following buttons value on QEMU:
> link:
> https://imgs.wiki/imgs/2023/04/28/2c6a92c33e2537dd.png
> > >
> > > From the screenshot we can know it didn't mark the mouse mode
> > > status > on original design,
> > > only set the actual button state. So I think have to mark it here >
> > > according to the value of 's->absolute'.
> > >
> Dear zack:
>
> I guess the last mail sent to you may has been lost
> as I don't see it in lore.kernel.org.Just resending it.

Do you mean the one I replied to yesterday? My reply to it is here
https://lore.kernel.org/lkml/3a4f27ad2122fe0457dc2a41a3b1b24ac556d26c.camel@vmware.com/
(and surely somewhere in your inbox as well)

z


      reply	other threads:[~2023-04-28  3:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <rk3ip31xbz-rk4smwgz5s@nsmail7.0.0--kylin--1>
2023-04-27  2:35 ` Re: [PATCH] Input: vmmouse - add macros to enable vmmouse relative mode Zack Rusin
2023-04-28  2:34 ` zongmin zhou
2023-04-28  3:35   ` Zack Rusin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0a986aaf5acf10af3a6a3a0220791d18d18df0e.camel@vmware.com \
    --to=zackr@vmware.com \
    --cc=Linux-graphics-maintainer@vmware.com \
    --cc=Pv-drivers@vmware.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhouzongmin@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).