From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DE8C432BE for ; Wed, 1 Sep 2021 20:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67DFE610A2 for ; Wed, 1 Sep 2021 20:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236087AbhIAUtg (ORCPT ); Wed, 1 Sep 2021 16:49:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231608AbhIAUtg (ORCPT ); Wed, 1 Sep 2021 16:49:36 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4085EC061575; Wed, 1 Sep 2021 13:48:39 -0700 (PDT) Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1F19883167; Wed, 1 Sep 2021 22:48:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1630529316; bh=2T5rBq5AOmeIkI3Raj9ncARJb3TtKXHxR9p4Ex+W+K4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=jy+RF8NFB/mc4mIL1/VU62JYjN/Uu0cuP3nt9NJolGmCfV+Xq0s2u09OJFdHZhYgO eWuIBveeU5FmDplJDCqCHT8aIF1US8VU4Xw/34Iu/mmgc3eUTk+ppS09ang1eVBw/J ND+mlhgt8BRxnnNKySn/wEaxsBpteFNUP8NYfTYVaafyJKtLdnwbWTp8yaa5wLregO aZL13wqFMvhuj38IGGZ2ytvrphD3jP3o1HK62eIK8otBNmSuKRbiJSRdI7txCvaRua 0kXD5eUoX1p8EhpXlP1Ly2us7LiXRO9QMsEZJcZPhhi2clsOWIri+sz9gX/jaNUNQQ vnBEx2g/BUP3Q== Subject: Re: [PATCH] Input: ili210x - Set the device name according to the device model To: Rogerio Pimentel Cc: dmitry.torokhov@gmail.com, hansemro@outlook.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210901192229.29864-1-rpimentel.silva@gmail.com> <4e8ad91c-2554-4b8f-94db-aa5add5f524d@denx.de> From: Marek Vasut Message-ID: Date: Wed, 1 Sep 2021 22:48:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 9/1/21 10:27 PM, Rogerio Pimentel wrote: > On Wed, Sep 1, 2021 at 4:46 PM Marek Vasut wrote: >> >> On 9/1/21 9:22 PM, Rogerio Pimentel wrote: >> >> [...] >> >>> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c >>> index 30576a5f2f04..ca7af4a6f588 100644 >>> --- a/drivers/input/touchscreen/ili210x.c >>> +++ b/drivers/input/touchscreen/ili210x.c >>> @@ -19,6 +19,8 @@ >>> #define ILI251X_DATA_SIZE1 31 >>> #define ILI251X_DATA_SIZE2 20 >>> >>> +#define ILI_NAME_LEN 27 >>> + >>> /* Touchscreen commands */ >>> #define REG_TOUCHDATA 0x10 >>> #define REG_PANEL_INFO 0x20 >>> @@ -394,6 +396,7 @@ static int ili210x_i2c_probe(struct i2c_client *client, >>> struct input_dev *input; >>> int error; >>> unsigned int max_xy; >>> + char *model_name; >>> >>> dev_dbg(dev, "Probing for ILI210X I2C Touschreen driver"); >>> >>> @@ -440,7 +443,11 @@ static int ili210x_i2c_probe(struct i2c_client *client, >>> i2c_set_clientdata(client, priv); >>> >>> /* Setup input device */ >>> - input->name = "ILI210x Touchscreen"; >>> + input->name = "Ilitek Touchscreen"; >>> + model_name = (char *)input->name; >>> + snprintf(model_name, ILI_NAME_LEN, "Ilitek %s Touchscreen", >> >> Which ilitek devices do you have available exactly ? >> >> There is a firmware interface which does report the device type, but I >> don't know whether it works on all the ilitek touchscreen devices. If it >> does, then it could be used here to pull the type from the firmware and >> then use this instead >> >> snprintf(model_name, ILI_NAME_LEN, "Ilitek ILI%04x Touchscreen", type); >> >> Try this command against the touch controller, it sends it command 0x61 >> and reads two bytes of the reply: >> i2ctransfer -f -y 1 w1@0x41 0x61 r2 >> 0x10 0x25 # <---- on ILI2510 it reports 0x25 0x10 in reverse > > Thanks for the comments and suggestions. I'll make the changes and send V2. Can you tell which ILI2xxx touch controller you have exactly ? Can you share the output of the 'i2ctransfer' (from i2c-tools) command above ?