Re: [PATCH RFC/RFT 1/3] dt-bindings: touchscreen: Add binding for Novatek NT36xxx series driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/10/2024 14:53, George Chan via B4 Relay wrote:
> From: George Chan <gchan9527@gmail.com>
> 
> Add binding for the Novatek NT36xxx series touchscreen driver.

Several issues here.
1. A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

2. Commit msg: Bindings are about hardware, not driver.

> 
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>

That's odd sequence.

> Signed-off-by: George Chan <gchan9527@gmail.com>
> ---
>  .../bindings/input/touchscreen/nt36xxx.yaml        | 70 ++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/nt36xxx.yaml b/Documentation/devicetree/bindings/input/touchscreen/nt36xxx.yaml
> new file mode 100644
> index 0000000000..3919f0d026
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/nt36xxx.yaml

Use compatible as filename.

> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/nt36xxx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT36xxx series touchscreen controller Bindings

Not tested.


> +
> +maintainers:
> +  - AngeloGioacchino Del Regno <kholk11@gmail.com>
> +  - George Chan <gchan9527@gmail.com>
> +
> +allOf:
> +  - $ref: touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +        - novatek,nt36525-spi
> +        - novatek,nt36672a-spi
> +        - novatek,nt36675-spi
> +        - novatek,nt36676f-spi
> +        - novatek,nt36772-spi

This just does not work and was not tested... Limited review follows:

Drop spi and explain why this cannot be part of existing nt36672a.

I finished review here.

Best regards,
Krzysztof