From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: soc@kernel.org, linux-kernel@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh@kernel.org>,
arm@kernel.org, linux-input@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node names to match all properties
Date: Tue, 5 Jul 2022 13:39:46 +0200 [thread overview]
Message-ID: <c2c1cf0c-9462-9ba5-a297-70d13a063de1@linaro.org> (raw)
In-Reply-To: <cab6fd96-4b8e-42a3-4dce-db63656df92c@linaro.org>
On 27/06/2022 10:17, Krzysztof Kozlowski wrote:
> On 16/06/2022 02:52, Krzysztof Kozlowski wrote:
>> The gpio-keys DT schema matches all properties with a wide pattern and
>> applies specific schema to children. This has drawback - all regular
>> properties are also matched and are silently ignored, even if they are
>> not described in schema. Basically this allows any non-object property
>> to be present.
>>
>> Enforce specific naming pattern for children (keys) to narrow the
>> pattern thus do not match other properties. This will require all
>> children to be properly prefixed or suffixed (button, event, switch or
>> key).
>>
>> Removal of "if:" within patternProperties causes drop of one indentation
>> level, but there are no other changes in the affected block.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> .../devicetree/bindings/input/gpio-keys.yaml | 157 +++++++++---------
>> 1 file changed, 77 insertions(+), 80 deletions(-)
>>
>
> Dmitry,
>
> Any comments from your side? Are you planning to pick up the dt-bindings
> here (patch 1-3)?
Hmmm, I guess this should go via dt-bindings then...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-05 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 0:52 [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children Krzysztof Kozlowski
2022-06-16 0:52 ` [PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node names to match all properties Krzysztof Kozlowski
2022-06-27 8:17 ` Krzysztof Kozlowski
2022-07-05 11:39 ` Krzysztof Kozlowski [this message]
2022-06-16 0:52 ` [PATCH v3 02/40] dt-bindings: input: gpio-keys: reference input.yaml and document properties Krzysztof Kozlowski
2022-06-16 0:52 ` [PATCH v3 03/40] dt-bindings: input: gpio-keys: accept also interrupt-extended Krzysztof Kozlowski
2022-06-18 3:02 ` (subset) [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children Nishanth Menon
2022-06-22 19:47 ` Heiko Stuebner
2022-07-03 3:56 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c1cf0c-9462-9ba5-a297-70d13a063de1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).