[PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children

[PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children

[Krzysztof Kozlowski]

Hi,

Merging
=======
1. dt-bindings: rebased on top of Rob's:
   https://lore.kernel.org/all/20220608211207.2058487-1-robh@kernel.org/

2. DTS patches are independent. They can be picked up directly by sub-arch
   maintainers, by Arnd or Olof, or eventually by me (if you wish).

Changes since v2
================
1. Few node renamings according to comments (at91, rockchip, nuvoton,wpcm450-pinctrl.yaml).
2. Add Rb tags.
3. Drop applied patches: allwinner, amlogic, broadcom and samsung.

Changes since v1
================
Patch 1: Extend gpio-keys nodes pattern to cover buttons, events and switches (Jeff).
Patch 2: Include input.yaml (Dmitry, Rob).
Patch 3: New patch.
New DTS patches.

Best regards,
Krzysztof

Krzysztof Kozlowski (40):
  dt-bindings: input: gpio-keys: enforce node names to match all
    properties
  dt-bindings: input: gpio-keys: reference input.yaml and document
    properties
  dt-bindings: input: gpio-keys: accept also interrupt-extended
  dt-bindings: pinctrl: nuvoton,wpcm450-pinctrl: align key node name
  arm64: dts: apm: correct gpio-keys properties
  arm64: dts: broadcom: align gpio-key node names with dtschema
  arm64: dts: freescale: align gpio-key node names with dtschema
  arm64: dts: freescale: align led node names with dtschema
  arm64: dts: hisilicon: align gpio-key node names with dtschema
  arm64: dts: hisilicon: correct gpio-keys properties
  arm64: dts: marvell: align gpio-key node names with dtschema
  arm64: dts: marvell: armada-3720: align lednode names with dtschema
  ARM: dts: marvell: align gpio-key node names with dtschema
  ARM: dts: marvell: correct gpio-keys properties
  arm64: dts: mediatek: align gpio-key node names with dtschema
  arm64: dts: mediatek: mt7622-bananapi-bpi-r64: align led node names
    with dtschema
  arm64: dts: mediatek: mt7622-rfb1: correct gpio-keys properties
  ARM: dts: mediatek: align gpio-key node names with dtschema
  arm64: dts: tegra: align gpio-key node names with dtschema
  ARM: dts: tegra: align gpio-key node names with dtschema
  arm64: dts: qcom: align gpio-key node names with dtschema
  arm64: dts: qcom: correct gpio-keys properties
  arm64: dts: qcom: sdm630-sony-xperia-nile: drop unneeded status from
    gpio-keys
  arm64: dts: qcom: align led node names with dtschema
  ARM: dts: qcom: align gpio-key node names with dtschema
  arm64: dts: rockchip: align gpio-key node names with dtschema
  ARM: dts: rockchip: align gpio-key node names with dtschema
  ARM: dts: rockchip: rk3288-tinker: correct gpio-keys properties
  arm64: dts: ti: align gpio-key node names with dtschema
  arm64: dts: xilinx: align gpio-key node names with dtschema
  ARM: dts: xilinx: align gpio-key node names with dtschema
  ARM: dts: omap: align gpio-key node names with dtschema
  ARM: dts: omap: correct gpio-keys properties
  ARM: dts: animeo: align gpio-key node names with dtschema
  ARM: dts: animeo: correct gpio-keys properties
  ARM: dts: aspeed: align gpio-key node names with dtschema
  ARM: dts: aspeed: correct gpio-keys properties
  ARM: dts: at91: align gpio-key node names with dtschema
  ARM: dts: at91: correct gpio-keys properties
  ARM: dts: at91: drop unneeded status from gpio-keys

 .../devicetree/bindings/input/gpio-keys.yaml  | 159 +++++++++---------
 .../pinctrl/nuvoton,wpcm450-pinctrl.yaml      |   2 +-
 arch/arm/boot/dts/am335x-evm.dts              |   8 +-
 arch/arm/boot/dts/am335x-guardian.dts         |   2 -
 .../boot/dts/am335x-moxa-uc-2100-common.dtsi  |   4 +-
 .../boot/dts/am335x-moxa-uc-8100-common.dtsi  |   4 +-
 arch/arm/boot/dts/am335x-pcm-953.dtsi         |   4 +-
 arch/arm/boot/dts/am335x-pepper.dts           |   8 +-
 arch/arm/boot/dts/am335x-shc.dts              |   6 +-
 arch/arm/boot/dts/am3517-evm-ui.dtsi          |  20 +--
 arch/arm/boot/dts/am3517-evm.dts              |  18 +-
 arch/arm/boot/dts/am437x-idk-evm.dts          |   6 +-
 arch/arm/boot/dts/animeo_ip.dts               |  10 +-
 arch/arm/boot/dts/armada-370-c200-v2.dts      |   8 +-
 arch/arm/boot/dts/armada-370-rd.dts           |   2 -
 .../boot/dts/armada-370-seagate-nas-xbay.dtsi |   8 +-
 .../armada-370-seagate-personal-cloud.dtsi    |   8 +-
 .../boot/dts/armada-381-netgear-gs110emx.dts  |   2 +-
 .../arm/boot/dts/armada-385-clearfog-gtr.dtsi |   4 +-
 arch/arm/boot/dts/armada-385-linksys.dtsi     |   4 +-
 .../arm/boot/dts/armada-388-clearfog-base.dts |   2 +-
 arch/arm/boot/dts/armada-388-clearfog.dts     |   2 +-
 arch/arm/boot/dts/armada-xp-axpwifiap.dts     |   6 +-
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts |   8 +-
 .../boot/dts/armada-xp-openblocks-ax3-4.dts   |   6 +-
 .../arm/boot/dts/aspeed-bmc-ampere-mtjade.dts |  30 ++--
 .../boot/dts/aspeed-bmc-bytedance-g220a.dts   |  48 +++---
 arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts  |  10 +-
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts  |  14 +-
 .../boot/dts/aspeed-bmc-inspur-fp5280g2.dts   |  22 +--
 arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts   |  23 +--
 arch/arm/boot/dts/aspeed-bmc-opp-mowgli.dts   |  20 +--
 arch/arm/boot/dts/aspeed-bmc-opp-nicole.dts   |   2 +-
 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts |   2 +-
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts  |   2 +-
 arch/arm/boot/dts/aspeed-bmc-opp-swift.dts    |  30 ++--
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts   |  14 +-
 arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dts   |   4 +-
 .../boot/dts/aspeed-bmc-opp-witherspoon.dts   |  16 +-
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts    |   4 +-
 arch/arm/boot/dts/at91-foxg20.dts             |   4 +-
 arch/arm/boot/dts/at91-gatwick.dts            |   2 +-
 arch/arm/boot/dts/at91-kizbox.dts             |   8 +-
 arch/arm/boot/dts/at91-kizbox2-common.dtsi    |  10 +-
 arch/arm/boot/dts/at91-kizbox3-hs.dts         |  12 +-
 arch/arm/boot/dts/at91-kizboxmini-common.dtsi |   6 +-
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts   |   2 +-
 arch/arm/boot/dts/at91-qil_a9260.dts          |   4 +-
 arch/arm/boot/dts/at91-sam9x60ek.dts          |   5 +-
 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts   |   4 +-
 arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dts |   5 +-
 arch/arm/boot/dts/at91-sama5d2_icp.dts        |   5 +-
 arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts     |   4 +-
 arch/arm/boot/dts/at91-sama5d2_xplained.dts   |   4 +-
 arch/arm/boot/dts/at91-sama5d3_xplained.dts   |   4 +-
 arch/arm/boot/dts/at91-sama5d4_xplained.dts   |   4 +-
 arch/arm/boot/dts/at91-sama5d4ek.dts          |   4 +-
 arch/arm/boot/dts/at91-sama7g5ek.dts          |   4 +-
 arch/arm/boot/dts/at91-wb45n.dts              |   7 +-
 arch/arm/boot/dts/at91-wb50n.dts              |  10 +-
 arch/arm/boot/dts/at91sam9260ek.dts           |   6 +-
 arch/arm/boot/dts/at91sam9261ek.dts           |  10 +-
 arch/arm/boot/dts/at91sam9263ek.dts           |   6 +-
 arch/arm/boot/dts/at91sam9g20ek_common.dtsi   |   6 +-
 .../dts/at91sam9g25-gardena-smart-gateway.dts |   2 +-
 arch/arm/boot/dts/at91sam9m10g45ek.dts        |  16 +-
 arch/arm/boot/dts/at91sam9n12ek.dts           |   4 +-
 arch/arm/boot/dts/at91sam9rlek.dts            |   6 +-
 arch/arm/boot/dts/mt7623a-rfb-emmc.dts        |   4 +-
 arch/arm/boot/dts/mt7623a-rfb-nand.dts        |   4 +-
 arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts |   4 +-
 arch/arm/boot/dts/mt7623n-rfb-emmc.dts        |   4 +-
 arch/arm/boot/dts/mt7629-rfb.dts              |   4 +-
 .../boot/dts/qcom-apq8064-asus-nexus7-flo.dts |   4 +-
 .../qcom-apq8064-sony-xperia-lagan-yuga.dts   |   8 +-
 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi |   2 +-
 arch/arm/boot/dts/qcom-ipq8064-rb3011.dts     |   4 +-
 arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi      |   6 +-
 .../qcom-msm8974-lge-nexus5-hammerhead.dts    |   4 +-
 .../dts/qcom-msm8974-sony-xperia-rhine.dtsi   |   8 +-
 .../dts/qcom-msm8974pro-fairphone-fp2.dts     |   6 +-
 .../boot/dts/qcom-msm8974pro-samsung-klte.dts |   6 +-
 ...-msm8974pro-sony-xperia-shinano-castor.dts |   8 +-
 arch/arm/boot/dts/rk3066a-bqcurie2.dts        |   4 +-
 arch/arm/boot/dts/rk3066a-rayeager.dts        |   2 +-
 arch/arm/boot/dts/rk3188-bqedison2qc.dts      |   4 +-
 arch/arm/boot/dts/rk3188-px3-evb.dts          |   2 +-
 arch/arm/boot/dts/rk3188-radxarock.dts        |   2 +-
 arch/arm/boot/dts/rk3229-evb.dts              |   2 +-
 arch/arm/boot/dts/rk3288-evb.dtsi             |   2 +-
 arch/arm/boot/dts/rk3288-firefly-reload.dts   |   2 +-
 arch/arm/boot/dts/rk3288-firefly.dtsi         |   2 +-
 arch/arm/boot/dts/rk3288-phycore-rdk.dts      |   4 +-
 arch/arm/boot/dts/rk3288-popmetal.dts         |   2 +-
 arch/arm/boot/dts/rk3288-r89.dts              |   2 +-
 arch/arm/boot/dts/rk3288-rock2-square.dts     |   2 +-
 arch/arm/boot/dts/rk3288-tinker.dtsi          |   4 +-
 .../boot/dts/rk3288-veyron-chromebook.dtsi    |   2 +-
 arch/arm/boot/dts/rk3288-veyron-minnie.dts    |   4 +-
 arch/arm/boot/dts/rk3288-veyron-pinky.dts     |   2 +-
 arch/arm/boot/dts/rk3288-veyron.dtsi          |   2 +-
 arch/arm/boot/dts/tegra114-asus-tf701t.dts    |   8 +-
 arch/arm/boot/dts/tegra114-dalmore.dts        |   8 +-
 arch/arm/boot/dts/tegra114-roth.dts           |   6 +-
 arch/arm/boot/dts/tegra114-tn7.dts            |   6 +-
 arch/arm/boot/dts/tegra124-apalis-eval.dts    |   2 +-
 .../boot/dts/tegra124-apalis-v1.2-eval.dts    |   2 +-
 arch/arm/boot/dts/tegra124-jetson-tk1.dts     |   2 +-
 arch/arm/boot/dts/tegra124-nyan.dtsi          |   4 +-
 arch/arm/boot/dts/tegra124-venice2.dts        |   2 +-
 .../boot/dts/tegra20-acer-a500-picasso.dts    |   8 +-
 arch/arm/boot/dts/tegra20-asus-tf101.dts      |   8 +-
 arch/arm/boot/dts/tegra20-colibri-eval-v3.dts |   2 +-
 arch/arm/boot/dts/tegra20-colibri-iris.dts    |   2 +-
 arch/arm/boot/dts/tegra20-harmony.dts         |   2 +-
 arch/arm/boot/dts/tegra20-paz00.dts           |   2 +-
 arch/arm/boot/dts/tegra20-seaboard.dts        |   4 +-
 arch/arm/boot/dts/tegra20-trimslice.dts       |   2 +-
 arch/arm/boot/dts/tegra20-ventana.dts         |   2 +-
 arch/arm/boot/dts/tegra30-apalis-eval.dts     |   2 +-
 .../arm/boot/dts/tegra30-apalis-v1.1-eval.dts |   2 +-
 .../tegra30-asus-nexus7-grouper-common.dtsi   |   8 +-
 .../dts/tegra30-asus-transformer-common.dtsi  |  10 +-
 arch/arm/boot/dts/tegra30-cardhu.dtsi         |   6 +-
 arch/arm/boot/dts/tegra30-colibri-eval-v3.dts |   2 +-
 arch/arm/boot/dts/tegra30-ouya.dts            |   2 +-
 .../arm/boot/dts/tegra30-pegatron-chagall.dts |  10 +-
 arch/arm/boot/dts/zynq-zc702.dts              |   4 +-
 arch/arm/boot/dts/zynq-zturn-common.dtsi      |   2 +-
 arch/arm64/boot/dts/apm/apm-merlin.dts        |   2 +-
 arch/arm64/boot/dts/apm/apm-mustang.dts       |   2 +-
 .../bcm4906-tplink-archer-c2300-v1.dts        |   8 +-
 .../bcm4908/bcm4908-asus-gt-ac5300.dts        |   8 +-
 .../boot/dts/freescale/fsl-ls1088a-ten64.dts  |  10 +-
 .../boot/dts/freescale/imx8mm-mx8menlo.dts    |   4 +-
 .../dts/freescale/imx8mm-var-som-symphony.dts |   6 +-
 .../dts/freescale/imx8mm-venice-gw700x.dtsi   |   8 +-
 .../dts/freescale/imx8mm-venice-gw7901.dts    |   8 +-
 .../dts/freescale/imx8mm-venice-gw7902.dts    |   8 +-
 .../dts/freescale/imx8mm-venice-gw7903.dts    |   6 +-
 .../boot/dts/freescale/imx8mm-verdin.dtsi     |   2 +-
 .../dts/freescale/imx8mn-var-som-symphony.dts |   6 +-
 .../dts/freescale/imx8mn-venice-gw7902.dts    |   8 +-
 .../boot/dts/freescale/imx8mp-verdin.dtsi     |   2 +-
 .../dts/freescale/imx8mq-librem5-devkit.dts   |   6 +-
 .../boot/dts/freescale/imx8mq-librem5.dtsi    |   4 +-
 .../boot/dts/freescale/imx8mq-nitrogen.dts    |   2 +-
 .../freescale/imx8qxp-colibri-eval-v3.dtsi    |   2 +-
 arch/arm64/boot/dts/freescale/mba8mx.dtsi     |   6 +-
 .../boot/dts/hisilicon/hi3660-hikey960.dts    |   2 +-
 arch/arm64/boot/dts/hisilicon/hip05-d02.dts   |   6 +-
 .../dts/marvell/armada-3720-turris-mox.dts    |   4 +-
 .../marvell/armada-8040-clearfog-gt-8k.dts    |   4 +-
 .../dts/mediatek/mt7622-bananapi-bpi-r64.dts  |  11 +-
 arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts  |   5 +-
 .../dts/mediatek/mt8173-elm-hana-rev7.dts     |   6 +-
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi  |  10 +-
 .../dts/mediatek/mt8183-kukui-jacuzzi.dtsi    |   4 +-
 .../dts/mediatek/mt8183-kukui-kakadu.dtsi     |   2 +-
 .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi |   2 +-
 .../boot/dts/mediatek/pumpkin-common.dtsi     |   4 +-
 .../arm64/boot/dts/nvidia/tegra132-norrin.dts |   4 +-
 .../boot/dts/nvidia/tegra186-p2771-0000.dts   |   6 +-
 .../nvidia/tegra186-p3509-0000+p3636-0001.dts |   6 +-
 .../boot/dts/nvidia/tegra194-p2972-0000.dts   |   4 +-
 .../boot/dts/nvidia/tegra194-p3509-0000.dtsi  |   4 +-
 .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi |   6 +-
 .../arm64/boot/dts/nvidia/tegra210-p2894.dtsi |   2 +-
 .../boot/dts/nvidia/tegra210-p3450-0000.dts   |   4 +-
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts |  10 +-
 .../nvidia/tegra234-p3737-0000+p3701-0000.dts |   6 +-
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts      |   4 +-
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts   |   6 +-
 .../boot/dts/qcom/msm8916-alcatel-idol347.dts |   2 +-
 .../arm64/boot/dts/qcom/msm8916-asus-z00l.dts |   4 +-
 .../arm64/boot/dts/qcom/msm8916-huawei-g7.dts |   2 +-
 .../boot/dts/qcom/msm8916-longcheer-l8150.dts |   2 +-
 .../boot/dts/qcom/msm8916-longcheer-l8910.dts |   2 +-
 .../qcom/msm8916-samsung-a2015-common.dtsi    |   6 +-
 .../boot/dts/qcom/msm8916-samsung-j5.dts      |   4 +-
 .../dts/qcom/msm8916-samsung-serranove.dts    |   6 +-
 .../dts/qcom/msm8916-wingtech-wt88047.dts     |   2 +-
 .../boot/dts/qcom/msm8992-xiaomi-libra.dts    |   6 +-
 .../dts/qcom/msm8994-msft-lumia-octagon.dtsi  |  10 +-
 .../qcom/msm8994-sony-xperia-kitakami.dtsi    |  12 +-
 .../boot/dts/qcom/msm8996-xiaomi-common.dtsi  |   6 +-
 .../boot/dts/qcom/msm8998-fxtec-pro1.dts      |  26 ++-
 .../boot/dts/qcom/msm8998-oneplus-common.dtsi |   6 +-
 .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi |   8 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi  |   2 +-
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi      |   2 +-
 .../dts/qcom/sdm630-sony-xperia-nile.dtsi     |  11 +-
 .../boot/dts/qcom/sdm632-fairphone-fp3.dts    |   2 +-
 .../boot/dts/qcom/sdm660-xiaomi-lavender.dts  |   2 +-
 arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi    |   2 +-
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts    |  10 +-
 .../boot/dts/qcom/sdm845-oneplus-common.dtsi  |   4 +-
 .../boot/dts/qcom/sdm845-shift-axolotl.dts    |   2 +-
 .../dts/qcom/sdm845-sony-xperia-tama.dtsi     |   2 +-
 .../boot/dts/qcom/sdm845-xiaomi-beryllium.dts |   2 +-
 .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts |   4 +-
 .../qcom/sm6125-sony-xperia-seine-pdx201.dts  |   4 +-
 .../boot/dts/qcom/sm7225-fairphone-fp4.dts    |   2 +-
 arch/arm64/boot/dts/qcom/sm8150-hdk.dts       |   4 +-
 .../dts/qcom/sm8150-microsoft-surface-duo.dts |   4 +-
 arch/arm64/boot/dts/qcom/sm8250-hdk.dts       |   4 +-
 .../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi |   2 +-
 .../dts/qcom/sm8350-sony-xperia-sagami.dtsi   |   2 +-
 arch/arm64/boot/dts/rockchip/rk3308-evb.dts   |   2 +-
 .../boot/dts/rockchip/rk3326-odroid-go2.dts   |  32 ++--
 .../boot/dts/rockchip/rk3328-nanopi-r2s.dts   |   2 +-
 arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi  |   2 +-
 .../boot/dts/rockchip/rk3368-geekbox.dts      |   2 +-
 .../dts/rockchip/rk3368-orion-r68-meta.dts    |   2 +-
 .../boot/dts/rockchip/rk3368-px5-evb.dts      |   2 +-
 arch/arm64/boot/dts/rockchip/rk3368-r88.dts   |   2 +-
 .../boot/dts/rockchip/rk3399-firefly.dts      |   2 +-
 .../dts/rockchip/rk3399-gru-chromebook.dtsi   |   2 +-
 .../boot/dts/rockchip/rk3399-gru-kevin.dts    |   2 +-
 .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi |   2 +-
 .../boot/dts/rockchip/rk3399-khadas-edge.dtsi |   2 +-
 .../boot/dts/rockchip/rk3399-nanopi-r4s.dts   |   4 +-
 .../boot/dts/rockchip/rk3399-nanopi4.dtsi     |   2 +-
 .../boot/dts/rockchip/rk3399-orangepi.dts     |   2 +-
 .../boot/dts/rockchip/rk3399-pinebook-pro.dts |   4 +-
 .../boot/dts/rockchip/rk3399-roc-pc.dtsi      |   2 +-
 .../boot/dts/rockchip/rk3399-rockpro64.dtsi   |   2 +-
 .../boot/dts/rockchip/rk3399-sapphire.dtsi    |   2 +-
 .../boot/dts/rockchip/rk3566-pinenote.dtsi    |   2 +-
 .../arm64/boot/dts/ti/k3-am654-base-board.dts |   4 +-
 .../dts/ti/k3-j721e-common-proc-board.dts     |   4 +-
 .../boot/dts/xilinx/zynqmp-sm-k26-revA.dts    |   2 +-
 .../boot/dts/xilinx/zynqmp-zcu100-revC.dts    |   2 +-
 .../boot/dts/xilinx/zynqmp-zcu102-revA.dts    |   2 +-
 .../boot/dts/xilinx/zynqmp-zcu106-revA.dts    |   2 +-
 .../boot/dts/xilinx/zynqmp-zcu111-revA.dts    |   2 +-
 236 files changed, 696 insertions(+), 757 deletions(-)

-- 
2.34.1

[PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node names to match all properties

[Krzysztof Kozlowski]

The gpio-keys DT schema matches all properties with a wide pattern and
applies specific schema to children.  This has drawback - all regular
properties are also matched and are silently ignored, even if they are
not described in schema.  Basically this allows any non-object property
to be present.

Enforce specific naming pattern for children (keys) to narrow the
pattern thus do not match other properties.  This will require all
children to be properly prefixed or suffixed (button, event, switch or
key).

Removal of "if:" within patternProperties causes drop of one indentation
level, but there are no other changes in the affected block.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/input/gpio-keys.yaml  | 157 +++++++++---------
 1 file changed, 77 insertions(+), 80 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
index 645dfa1e0d07..27bb5c6ab8d9 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
@@ -16,86 +16,83 @@ properties:
       - gpio-keys-polled
 
 patternProperties:
-  ".*":
-    if:
-      type: object
-    then:
-      $ref: input.yaml#
-
-      properties:
-        gpios:
-          maxItems: 1
-
-        interrupts:
-          maxItems: 1
-
-        label:
-          description: Descriptive name of the key.
-
-        linux,code:
-          description: Key / Axis code to emit.
-
-        linux,input-type:
-          default: 1  # EV_KEY
-
-        linux,input-value:
-          description: |
-            If linux,input-type is EV_ABS or EV_REL then this
-            value is sent for events this button generates when pressed.
-            EV_ABS/EV_REL axis will generate an event with a value of 0
-            when all buttons with linux,input-type == type and
-            linux,code == axis are released. This value is interpreted
-            as a signed 32 bit value, e.g. to make a button generate a
-            value of -1 use:
-
-            linux,input-value = <0xffffffff>; /* -1 */
-
-          $ref: /schemas/types.yaml#/definitions/uint32
-
-        debounce-interval:
-          description:
-            Debouncing interval time in milliseconds. If not specified defaults to 5.
-          $ref: /schemas/types.yaml#/definitions/uint32
-
-          default: 5
-
-        wakeup-source:
-          description: Button can wake-up the system.
-
-        wakeup-event-action:
-          description: |
-            Specifies whether the key should wake the system when asserted, when
-            deasserted, or both. This property is only valid for keys that wake up the
-            system (e.g., when the "wakeup-source" property is also provided).
-
-            Supported values are defined in linux-event-codes.h:
-
-              EV_ACT_ANY        - both asserted and deasserted
-              EV_ACT_ASSERTED   - asserted
-              EV_ACT_DEASSERTED - deasserted
-          $ref: /schemas/types.yaml#/definitions/uint32
-          enum: [0, 1, 2]
-
-        linux,can-disable:
-          description:
-            Indicates that button is connected to dedicated (not shared) interrupt
-            which can be disabled to suppress events from the button.
-          type: boolean
-
-      required:
-        - linux,code
-
-      anyOf:
-        - required:
-            - interrupts
-        - required:
-            - gpios
-
-      dependencies:
-        wakeup-event-action: [ wakeup-source ]
-        linux,input-value: [ gpios ]
-
-      unevaluatedProperties: false
+  "^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$":
+    $ref: input.yaml#
+
+    properties:
+      gpios:
+        maxItems: 1
+
+      interrupts:
+        maxItems: 1
+
+      label:
+        description: Descriptive name of the key.
+
+      linux,code:
+        description: Key / Axis code to emit.
+
+      linux,input-type:
+        default: 1  # EV_KEY
+
+      linux,input-value:
+        description: |
+          If linux,input-type is EV_ABS or EV_REL then this
+          value is sent for events this button generates when pressed.
+          EV_ABS/EV_REL axis will generate an event with a value of 0
+          when all buttons with linux,input-type == type and
+          linux,code == axis are released. This value is interpreted
+          as a signed 32 bit value, e.g. to make a button generate a
+          value of -1 use:
+
+          linux,input-value = <0xffffffff>; /* -1 */
+
+        $ref: /schemas/types.yaml#/definitions/uint32
+
+      debounce-interval:
+        description:
+          Debouncing interval time in milliseconds. If not specified defaults to 5.
+        $ref: /schemas/types.yaml#/definitions/uint32
+
+        default: 5
+
+      wakeup-source:
+        description: Button can wake-up the system.
+
+      wakeup-event-action:
+        description: |
+          Specifies whether the key should wake the system when asserted, when
+          deasserted, or both. This property is only valid for keys that wake up the
+          system (e.g., when the "wakeup-source" property is also provided).
+
+          Supported values are defined in linux-event-codes.h:
+
+            EV_ACT_ANY        - both asserted and deasserted
+            EV_ACT_ASSERTED   - asserted
+            EV_ACT_DEASSERTED - deasserted
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1, 2]
+
+      linux,can-disable:
+        description:
+          Indicates that button is connected to dedicated (not shared) interrupt
+          which can be disabled to suppress events from the button.
+        type: boolean
+
+    required:
+      - linux,code
+
+    anyOf:
+      - required:
+          - interrupts
+      - required:
+          - gpios
+
+    dependencies:
+      wakeup-event-action: [ wakeup-source ]
+      linux,input-value: [ gpios ]
+
+    unevaluatedProperties: false
 
 if:
   properties:
-- 
2.34.1

[PATCH v3 02/40] dt-bindings: input: gpio-keys: reference input.yaml and document properties

[Krzysztof Kozlowski]

The original text bindings documented "autorepeat" and "label"
properties (in the device node, beside the nodes with keys).  DTS use
also poll-interval.  Reference the input.yaml to get these top-level
properties.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/input/gpio-keys.yaml  | 32 +++++++++++--------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
index 27bb5c6ab8d9..e722e681d237 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
@@ -15,6 +15,13 @@ properties:
       - gpio-keys
       - gpio-keys-polled
 
+  autorepeat: true
+
+  label:
+    description: Name of entire device
+
+  poll-interval: true
+
 patternProperties:
   "^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$":
     $ref: input.yaml#
@@ -94,19 +101,18 @@ patternProperties:
 
     unevaluatedProperties: false
 
-if:
-  properties:
-    compatible:
-      const: gpio-keys-polled
-then:
-  properties:
-    poll-interval:
-      description:
-        Poll interval time in milliseconds
-      $ref: /schemas/types.yaml#/definitions/uint32
-
-  required:
-    - poll-interval
+allOf:
+  - $ref: input.yaml#
+  - if:
+      properties:
+        compatible:
+          const: gpio-keys-polled
+    then:
+      required:
+        - poll-interval
+    else:
+      properties:
+        poll-interval: false
 
 additionalProperties: false
 
-- 
2.34.1

[PATCH v3 03/40] dt-bindings: input: gpio-keys: accept also interrupt-extended

[Krzysztof Kozlowski]

Each key device node might have interrupts-extended instead of
interrupts property:

  fsl-ls1028a-kontron-sl28-var1.dtb: buttons0: power-button: 'anyOf' conditional failed, one must be fixed:
    'interrupts' is a required property
    'gpios' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
index e722e681d237..17ac9dff7972 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
@@ -92,6 +92,8 @@ patternProperties:
     anyOf:
       - required:
           - interrupts
+      - required:
+          - interrupts-extended
       - required:
           - gpios
 
-- 
2.34.1

Re: (subset) [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children

[Nishanth Menon]

Hi Krzysztof Kozlowski,

On Wed, 15 Jun 2022 17:52:24 -0700, Krzysztof Kozlowski wrote:
> Merging
> =======
> 1. dt-bindings: rebased on top of Rob's:
>    https://lore.kernel.org/all/20220608211207.2058487-1-robh@kernel.org/
> 
> 2. DTS patches are independent. They can be picked up directly by sub-arch
>    maintainers, by Arnd or Olof, or eventually by me (if you wish).
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[29/40] arm64: dts: ti: align gpio-key node names with dtschema
        commit: 85423386c9763fb20159892631eccc481a2d9b71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: (subset) [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children

[Heiko Stuebner]

On Wed, 15 Jun 2022 17:52:24 -0700, Krzysztof Kozlowski wrote:
> Merging
> =======
> 1. dt-bindings: rebased on top of Rob's:
>    https://lore.kernel.org/all/20220608211207.2058487-1-robh@kernel.org/
> 
> 2. DTS patches are independent. They can be picked up directly by sub-arch
>    maintainers, by Arnd or Olof, or eventually by me (if you wish).
> 
> [...]

Applied, thanks!

[26/40] arm64: dts: rockchip: align gpio-key node names with dtschema
        commit: 517ed0ffd3cc691bef747288d51d01d2705b2251

        In the pinenote dts the original patch changed "cover" to
        switch, so to keep the cover information intact, I changed
        the node to "switch-cover" ... similar to other "switch-lid"
        instances in some other Rockchip devicetrees.

[27/40] ARM: dts: rockchip: align gpio-key node names with dtschema
        commit: 271e2c92285075a890c58cba9ad5979a8959f6ff
[28/40] ARM: dts: rockchip: rk3288-tinker: correct gpio-keys properties
        commit: e5a3cbe8b45b0a436a39cc969b7bcc8353248018

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node names to match all properties

[Krzysztof Kozlowski]

On 16/06/2022 02:52, Krzysztof Kozlowski wrote:
> The gpio-keys DT schema matches all properties with a wide pattern and
> applies specific schema to children.  This has drawback - all regular
> properties are also matched and are silently ignored, even if they are
> not described in schema.  Basically this allows any non-object property
> to be present.
> 
> Enforce specific naming pattern for children (keys) to narrow the
> pattern thus do not match other properties.  This will require all
> children to be properly prefixed or suffixed (button, event, switch or
> key).
> 
> Removal of "if:" within patternProperties causes drop of one indentation
> level, but there are no other changes in the affected block.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/input/gpio-keys.yaml  | 157 +++++++++---------
>  1 file changed, 77 insertions(+), 80 deletions(-)
> 

Dmitry,

Any comments from your side? Are you planning to pick up the dt-bindings
here (patch 1-3)?

Best regards,
Krzysztof

Re: (subset) [PATCH v3 00/40] dt-bindings: input: gpio-keys: rework matching children

[Bjorn Andersson]

On Wed, 15 Jun 2022 17:52:24 -0700, Krzysztof Kozlowski wrote:
> Merging
> =======
> 1. dt-bindings: rebased on top of Rob's:
>    https://lore.kernel.org/all/20220608211207.2058487-1-robh@kernel.org/
> 
> 2. DTS patches are independent. They can be picked up directly by sub-arch
>    maintainers, by Arnd or Olof, or eventually by me (if you wish).
> 
> [...]

Applied, thanks!

[25/40] ARM: dts: qcom: align gpio-key node names with dtschema
        commit: 9c17baaa97c89379cbd89e36115b7fb6aba43518

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

Re: [PATCH v3 01/40] dt-bindings: input: gpio-keys: enforce node names to match all properties

[Krzysztof Kozlowski]

On 27/06/2022 10:17, Krzysztof Kozlowski wrote:
> On 16/06/2022 02:52, Krzysztof Kozlowski wrote:
>> The gpio-keys DT schema matches all properties with a wide pattern and
>> applies specific schema to children.  This has drawback - all regular
>> properties are also matched and are silently ignored, even if they are
>> not described in schema.  Basically this allows any non-object property
>> to be present.
>>
>> Enforce specific naming pattern for children (keys) to narrow the
>> pattern thus do not match other properties.  This will require all
>> children to be properly prefixed or suffixed (button, event, switch or
>> key).
>>
>> Removal of "if:" within patternProperties causes drop of one indentation
>> level, but there are no other changes in the affected block.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>  .../devicetree/bindings/input/gpio-keys.yaml  | 157 +++++++++---------
>>  1 file changed, 77 insertions(+), 80 deletions(-)
>>
> 
> Dmitry,
> 
> Any comments from your side? Are you planning to pick up the dt-bindings
> here (patch 1-3)?

Hmmm, I guess this should go via dt-bindings then...

Best regards,
Krzysztof