From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Niestroj Subject: Re: [PATCH v4 1/5] mfd: tps65217: Add support for IRQs Date: Mon, 29 Aug 2016 11:05:34 +0200 Message-ID: References: <20160620105056.25843-1-m.niestroj@grinn-global.com> <20160620105056.25843-2-m.niestroj@grinn-global.com> <576D0437.1020800@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp2.megiteam.pl ([213.189.52.193]:54369 "EHLO smtp2.megiteam.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbcH2JFt (ORCPT ); Mon, 29 Aug 2016 05:05:49 -0400 In-Reply-To: <576D0437.1020800@ti.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Lee Jones Cc: Grygorii Strashko , Tony Lindgren , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Rob Herring , Pawel Moll , linux-omap@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org ping On 24.06.2016 11:58, Grygorii Strashko wrote: > On 06/20/2016 01:50 PM, Marcin Niestroj wrote: >> Add support for handling IRQs: power button, AC and USB power state >> changes. Mask and interrupt bits are shared within one register, which >> prevents us to use regmap_irq implementation. New irq_domain is >> created in >> order to add interrupt handling for each tps65217's subsystem. IRQ >> resources have been added for charger subsystem to be able to notify >> about >> AC and USB state changes. >> >> Signed-off-by: Marcin Niestroj >> Acked-by: Lee Jones >> --- >> Changes v3 -> v4 (suggested by Grygorii): >> * Add irq_set_parent() during irq init >> * Remove hardcoded IRQ trigger type, rely on DT bindings instead >> >> Changes v2 -> v3 (suggested by Lee): >> * Alphabetical reorder of includes >> * Rename enum tps65217_irqs -> tps65217_irq_type, so we won't confuse >> it with structure object with the same name. >> * Fix inconsistent order of irq_enable and irq_disable >> * Remove redundant 'else' when returning from tps65217_irq_thread >> >> Changes v1 -> v2: none >> >> drivers/mfd/Kconfig | 1 + >> drivers/mfd/tps65217.c | 195 >> +++++++++++++++++++++++++++++++++++++++++-- >> include/linux/mfd/tps65217.h | 12 +++ >> 3 files changed, 200 insertions(+), 8 deletions(-) >> > > Reviewed-by: Grygorii Strashko > > > -- Marcin Niestroj