From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jeff LaBundy <jeff@labundy.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH] dt-bindings: input: use generic node names
Date: Sun, 29 May 2022 16:21:12 +0200 [thread overview]
Message-ID: <c4c17cde-686b-4f4e-65dc-9b8c41894bf2@linaro.org> (raw)
In-Reply-To: <20220527224401.GA395557@nixie71>
On 28/05/2022 00:44, Jeff LaBundy wrote:
> Hi Krzysztof,
>
> On Tue, May 24, 2022 at 11:31:36AM +0200, Krzysztof Kozlowski wrote:
>> Devicetree specification expects nodes to have generic names, if
>> possible, so replace custom ones with something generic. For gpio-keys,
>> the more popular format is "key-xxx" instead of "xxx-key", so choose the
>> first one.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Andreas Kemnade <andreas@kemnade.info>
>> ---
>> .../devicetree/bindings/input/fsl,mpr121-touchkey.yaml | 4 ++--
>> Documentation/devicetree/bindings/input/gpio-keys.yaml | 4 ++--
>> Documentation/devicetree/bindings/input/iqs269a.yaml | 2 +-
>> Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
>
> For iqs*a.yaml:
>
> Acked-by: Jeff LaBundy <jeff@labundy.com>
>
> Does there happen to be a list of preferred names based on device
> function, or is it simply a matter of what seems to be most common?
Devicetree spec has examples of names, but of course it does not cover
many of cases. Here I chosen mixture of device function and most common
(e.g. touch for touch controller).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-29 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 9:31 [PATCH] dt-bindings: input: use generic node names Krzysztof Kozlowski
2022-05-24 11:11 ` Andreas Kemnade
2022-05-24 11:28 ` Krzysztof Kozlowski
2022-05-26 2:20 ` Rob Herring
2022-05-27 22:44 ` Jeff LaBundy
2022-05-29 14:21 ` Krzysztof Kozlowski [this message]
2022-05-28 20:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4c17cde-686b-4f4e-65dc-9b8c41894bf2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).