From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Another HID problem this merge window..
Date: Sat, 27 Oct 2018 12:36:05 -0700 [thread overview]
Message-ID: <c6b7e5b26883c53db35454e9b0ffb44898517228.camel@perches.com> (raw)
In-Reply-To: <CAHk-=wiZ24JuVehJ5sEC0UG1Gk2nvB363wO02RRsR1oEht6R9Q@mail.gmail.com>
On Sat, 2018-10-27 at 11:13 -0700, Linus Torvalds wrote:
> Ok, so this is a much smaller issue than the i2c one that cause boot
> problems, but it's annoying.
>
> We do *not* enable new random drivers by default. And we most
> *definitely* don't do it when they are odd-ball ones that most people
> have never heard of.
>
> Yet the new "BigBen Interactive" driver that was added this merge
> window did exactly that.
In fairness, it seems many of the HID drivers do exactly that
and this could have been a "copy from example" addition.
$ git grep -P -i -B2 'default\s+\!EXPERT' -- drivers/hid/Kconfig
drivers/hid/Kconfig- tristate "A4 tech mice"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Apple {i,Power,Mac}Books"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Belkin Flip KVM and Wireless keyboard"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Cherry Cymotion keyboard"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Chicony devices"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Cypress mouse and barcode readers"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Ezkey BTC 8193 keyboard"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "ITE devices"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Kensington Slimblade Trackball"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
--
drivers/hid/Kconfig- tristate "Logitech devices"
drivers/hid/Kconfig- depends on HID
drivers/hid/Kconfig: default !EXPERT
next prev parent reply other threads:[~2018-10-27 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 18:13 Another HID problem this merge window Linus Torvalds
2018-10-27 19:36 ` Joe Perches [this message]
2018-10-27 20:17 ` Linus Torvalds
2018-10-27 21:45 ` Jiri Kosina
2018-10-29 8:49 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6b7e5b26883c53db35454e9b0ffb44898517228.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox