From: Mario Limonciello <mario.limonciello@amd.com>
To: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Input: i8042: Avoid probing if no keyboard and mouse are set in quirks
Date: Thu, 7 Dec 2023 14:39:58 -0600 [thread overview]
Message-ID: <c7296e7c-8920-4bd7-b2a8-c5dc6ffdee03@amd.com> (raw)
In-Reply-To: <87il5bgfmp.fsf@nvidia.com>
On 12/6/2023 15:55, Rahul Rameshbabu wrote:
> On Wed, 06 Dec, 2023 15:21:39 -0600 Mario Limonciello <mario.limonciello@amd.com> wrote:
>> Some laptops have an i8042 controller in the SOC, nothing mentioned in
>> ACPI PNP and nothing connected to the controller. Add the ability to
>> skip probing in this case.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>
> Thanks. I think this is a good choice for handling the issue you
> presented with the Framework 16.
>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Thanks!
Dmitry,
Are you OK with this? The other direction I considered was to add a DMI
BIOS year check and "only continue to probe" non PNP devices on systems
older than 2023.
That could let you cut and run without needing to continue to add quirks
like this but it could be riskier.
prev parent reply other threads:[~2023-12-07 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 21:21 [PATCH v2 1/2] Input: i8042: Avoid probing if no keyboard and mouse are set in quirks Mario Limonciello
2023-12-06 21:21 ` [PATCH v2 2/2] Input: i8042: Add a quirk for Framework 16" laptop Mario Limonciello
2023-12-06 21:54 ` Rahul Rameshbabu
2023-12-08 17:57 ` Dmitry Torokhov
2023-12-08 18:08 ` Rahul Rameshbabu
2023-12-08 18:22 ` Mario Limonciello
2023-12-06 21:55 ` [PATCH v2 1/2] Input: i8042: Avoid probing if no keyboard and mouse are set in quirks Rahul Rameshbabu
2023-12-07 20:39 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7296e7c-8920-4bd7-b2a8-c5dc6ffdee03@amd.com \
--to=mario.limonciello@amd.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).