From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.178 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792551058; b=cpTlk9zVFW+AAhjTmChMCyjHklDQP1n7mNQ22czo//7V25Y9kp8wggNYWRAqvfKLgoTU 486nnMM8Oeyzd+O5Byw8JXKKzwyuGqwhVvic3tXBvplWA9UBhN0jvTWIsz7F/rDn1e3g1 24exLMBGnbgzprLxzsYd0quvTINayxGn8eymZqIHthTXckWQqSpZpJrBMzlm8ihrsDCBT fghUVp53fvASQVeHtqG8PXklNy0L2Fvlsiea0CMR0ndCP4MjxoUC9MW8D0h+XpAx/0uE7 zalKoENzIaVH7/IkppQXv/SOEtv8R+7ShW5zEkDPxGF7M+145C+iPSuzrECwOHYbNqg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792551058; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=GHpCiXrobtjq+79vNH0JP2GJuLZO5PYviPAXuNKXvXU=; b=HlZ3WGjdU/+c/zo57EK1QqJ2Ygnpu/KDhU1lDN6PdUbaPhp6TD2WX4MWyqNv1yhtzz9I vW3oQzk12xfg8z7rdv1V94WWmPP/81fvnzt72Ox+v3c6mbIq+rcQJ6iccIyzX2YSEjT06 7VVoytGrZhFHYhGrMrcobUkhtPq62/3Qo4ewNnpprgc0RWw3xbrYd/daHcu9nW+HR9y+Q /IutFWYZIvC4KDJhoIAVtxz2n01230VQ8KnhiggNYTgJ/tbn2U8fRUfSsIQ17PxCZX855 GnaF3aiVwYfJXBWc/FDgXzSmUvq7upPSLV6r1UowMxfTpew7vfjmYu49pRJz3K6VbVw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=rOOW0LFU; arc=none smtp.remote-ip=209.85.214.178 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D661606A32E for ; Wed, 21 Oct 2026 02:50:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6D661606A32E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=rOOW0LFU Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2e9cf928dc9so6871895ad.0 for ; Tue, 20 Oct 2026 19:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792551057; x=1793155857; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:mime-version :user-agent:date:message-id:from:cc:references:to:subject:from:to:cc :subject:date:message-id:reply-to:content-type; bh=GHpCiXrobtjq+79vNH0JP2GJuLZO5PYviPAXuNKXvXU=; b=rOOW0LFU9Nic3tkOfZ9safmfimFzgnPg9RA53cW9fNyVz/eMwOnmSZrIEBqalv//pz glfYocPPfaEcDdpqjRwf0FRJQD+ue9nkh3LpNi7g2yH9UEOzhltZ5TLYsq/mLT8Cq+/x 81G2rNC+kc5IS/UzHptyk/JOiT9LzoIl8mDq5ggaQWsI8Bj4xxiiMhfQ0pECKDz3rEdt 4jz99mnn5mWI13md7lxwwiiEuDMn6z9bNj80RCcOW1jJHGnG2EO+Z2LCHIfsKgJQvCAG 2+tWDaGpfBXMEgwm53lxLVnb0oNsVIlFBPAK6JmfSk0M5+j29A8/K7es4FeeYvIjZ7ll aW2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792551057; x=1793155857; h=content-transfer-encoding:content-type:in-reply-to:mime-version :user-agent:date:message-id:from:cc:references:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GHpCiXrobtjq+79vNH0JP2GJuLZO5PYviPAXuNKXvXU=; b=LalsS5Owqw0jX7AoO9+sh9MONyQI4meKOa4k6SD8SDjY6vwh9e+oNmYQGaUT8NcDO8 9K3G6CuleIhTYYkDzndus/1nMtdauH6Nt0sa1Huc8tz8tapo4ITmhbxk8839M8YuvY/h v32J64N0j0yj+ngWOzR9Zh6FC8DwmCWwdybhpbY1fL845zAcsaGFud+7T2ZUf+x4BhVF jSa7sIDvPRz02TPGJjJP15Soq7qW5RLrOsqS12uY7FpeaZfxNEkZLLhWnzkWHdOHgrYy 0iWQ31GyplAEp/QWkrom8PjDyokW5TCPILE0LruHzrjmAq0bZLeeO58EhsLf6bxtkNhZ TtGA== X-Forwarded-Encrypted: i=1; AKwUvBxQKj059EiwMwN6ECaiLgMNFhpH+ZjdIjq0AbGHO+IZIhty0zwBc6BWinhTy+AaFBLRuC78CKnuwYonZw==@vger.kernel.org X-Gm-Message-State: AFq9FYJiGMhBA/HyWTZboXj3+NE9PBhvRbq9+0Nucf9b5acEVe76Cjo+ jB1YiA2IpLko29Blb6npJPUx90k5QEKQtpqsXFMUjFyravNio6n9psJo X-Gm-Gg: AYBFou2L7mMublIzDyJ6ckHxFzH/APIrzTbhtrjZ2zCKquCueFUfb2S+1gWUMO0v6XA sQBoFBUNkjL6QOusPVozZEvti17kLOsww0If2F5iye301/NOiuO/srFYpK/WdgxOkxFFNQDURAk UYGph9liYENMie+DE/y/UNNrN7uax/3fuGHMat+ni2DBqzuk6pwQvv9BqWj6JTwUwFJFBLDZ6MB UoeKZqmDhD0VQgkGqCku2XQig6pVfsnhbhg2fDWfIUiqgsf7bsvSJVx2pQC8iFDm9dqk3RaFj0S LLq9NGOoZpZAaYMgOA5SGyZWijlpZ3r5tD3QTvAjcdIE5Gl8S6qHZ9BtKS/U0eLDIVjMFKXfTS+ Gk94fpEr98NKR6NNcshOWAabDuSEeLs9baTufQmYTtpqili6CEUL9UL/1seh8cOAScEFpipmIFt cyYhmasF68++mrP2M27sUgOij6lZS0bD2WFOuY7q99muKKauC9BZ9ujj8kpuk8yDdn7mV1vQb89 Ed9eYlyoT0YzbJKfG7V01NCLXfbKROO1PzJQgiTRzLAJ5Di9lRBzQPyFrOuVCcDnbZgMYRy5TPh yiL9nLa8YaE= X-Received: by 2002:a17:90b:4e8e:b0:3ac:36c7:c144 with SMTP id 98e67ed59e1d1-3ad86f28703mr395508a91.28.1792551056635; Tue, 20 Oct 2026 19:50:56 -0700 (PDT) Received: from [10.1.1.24] (122-59-250-182-adsl.sparkbb.co.nz. [122.59.250.182]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ad80fc21dcsm1837926a91.7.2026.10.20.19.50.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2026 19:50:56 -0700 (PDT) Subject: Re: [PATCH v5] m68k: Fix atari mouse movement To: Miro Kropacek , geert@linux-m68k.org, dmitry.torokhov@gmail.com References: <20261021000338.2160223-1-miro.kropacek@gmail.com> <20261021022336.2232886-1-miro.kropacek@gmail.com> Cc: linux-m68k@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: Michael Schmitz Message-ID: Date: Wed, 21 Oct 2026 15:50:49 +1300 User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:45.0) Gecko/20100101 Icedove/45.4.0 X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 In-Reply-To: <20261021022336.2232886-1-miro.kropacek@gmail.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Hi Miro, Am 21.10.2026 um 15:23 schrieb Miro Kropacek: > Kernels are built with -funsigned-char since version 6.2, resulting in > the signed 8-bit position deltas reported by the IKBD being > misinterpreted as unsigned. > > The hook is handed a raw IKBD packet, so take it as a byte stream and > apply the sign to the two displacement values alone. > > Fixes: 3bc753c06dd02a35 ("kbuild: treat char as always unsigned") > Link: https://lists.debian.org/debian-68k/2026/08/msg00000.html > Suggested-by: Dmitry Torokhov > Signed-off-by: Miro Kropacek > Cc: linux-input > --- > > Changes in v5: > > - take the packet as u8 * and cast only the two displacement values, > as suggested; this drops the call-site cast v4 needed, and with it > the -Wpointer-sign warning > - add the types include atarikb.h now relies on > > The same cast of the two displacement values was tested on an Atari > Falcon030 with CT60 in v1 of this patch; v5 differs from it only in the > type of the hook argument. > > Michael's Reviewed-by from v3 is dropped, as the approach has changed > twice since. Dmitry's reasoning makes sense to me, so we're back on v1 with no change in functionality. Looks good to me, feel free to add my Reviewed-by if it helps get this merged. Cheers, Michael > > arch/m68k/atari/atakeyb.c | 2 +- > arch/m68k/include/asm/atarikb.h | 4 +++- > drivers/input/mouse/atarimouse.c | 6 +++--- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c > index 49a9a459bdf4..b715e2b8351c 100644 > --- a/arch/m68k/atari/atakeyb.c > +++ b/arch/m68k/atari/atakeyb.c > @@ -39,7 +39,7 @@ void (*atari_MIDI_interrupt_hook) (void); > /* Hook for keyboard inputdev driver */ > void (*atari_input_keyboard_interrupt_hook) (unsigned char, char); > /* Hook for mouse inputdev driver */ > -void (*atari_input_mouse_interrupt_hook) (char *); > +void (*atari_input_mouse_interrupt_hook)(u8 *buf); > EXPORT_SYMBOL(atari_input_keyboard_interrupt_hook); > EXPORT_SYMBOL(atari_input_mouse_interrupt_hook); > > diff --git a/arch/m68k/include/asm/atarikb.h b/arch/m68k/include/asm/atarikb.h > index 68f3622bf591..bdf67bff1472 100644 > --- a/arch/m68k/include/asm/atarikb.h > +++ b/arch/m68k/include/asm/atarikb.h > @@ -15,6 +15,8 @@ > #ifndef _LINUX_ATARIKB_H > #define _LINUX_ATARIKB_H > > +#include > + > void ikbd_write(const char *, int); > void ikbd_mouse_button_action(int mode); > void ikbd_mouse_rel_pos(void); > @@ -37,7 +39,7 @@ extern void (*atari_MIDI_interrupt_hook) (void); > /* Hook for keyboard inputdev driver */ > extern void (*atari_input_keyboard_interrupt_hook) (unsigned char, char); > /* Hook for mouse inputdev driver */ > -extern void (*atari_input_mouse_interrupt_hook) (char *); > +extern void (*atari_input_mouse_interrupt_hook)(u8 *buf); > > int atari_keyb_init(void); > > diff --git a/drivers/input/mouse/atarimouse.c b/drivers/input/mouse/atarimouse.c > index b1219cc4d9a2..c5b794262e85 100644 > --- a/drivers/input/mouse/atarimouse.c > +++ b/drivers/input/mouse/atarimouse.c > @@ -60,7 +60,7 @@ extern int atari_mouse_buttons; > > static struct input_dev *atamouse_dev; > > -static void atamouse_interrupt(char *buf) > +static void atamouse_interrupt(u8 *buf) > { > int buttons, dx, dy; > > @@ -71,8 +71,8 @@ static void atamouse_interrupt(char *buf) > #endif > > /* only relative events get here */ > - dx = buf[1]; > - dy = buf[2]; > + dx = (s8)buf[1]; > + dy = (s8)buf[2]; > > input_report_rel(atamouse_dev, REL_X, dx); > input_report_rel(atamouse_dev, REL_Y, dy); >