From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F14478E57 for ; Thu, 10 Sep 2026 20:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789070777; cv=none; b=Bj6QdaUXmrMpA1mR27iHKi7H+RsFD5u1wDYbL4qr1RRgLHezzc7glKIg+HARj4cfroRtJtVtswQF4CqcpYqTRNDehOFnoxfHSIMXXaXXmb3WK4CsxzUigrQUzsaiO1jbMGUmEmAQdHgBGg7zrPa14PGTgO45tHi+j0QKGxjndpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789070777; c=relaxed/simple; bh=+FZf8w7gamtymKEs4poKhSyNIKqgP3DcWJ746AYEo3s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BFQxniQPexLgdjadWdrjrjjxwQ6Fr2Z09eIL+CAsw60IPPSZ07YFTFHBRkt18L8V2zkGPMz/9Oy9VfYgm31e7tuMuU8wxntZW2JSzT0p3MIP0DElPQ86WY99Y+hlsNAqXZWeuGmuZR0lndBIg20zus0jbJxH6ZKrDYozMhs/rnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EcQUTQwm; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EcQUTQwm" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-cc147d86bebso285047a12.0 for ; Thu, 10 Sep 2026 13:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789070775; x=1789675575; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CUgV2Sz6/P7makCPies8cUT1nvpwJR9dBUWK+1kW95Y=; b=EcQUTQwm+DBXd4lrjFG7SfE5drpB3UJ2MDzzmPMr4bNS537s1vCFZiaepIIPxbaULb i+W9FRhXNHgFQybiCBWUoA/x9axUI2ROn0GKEcEA+EANXyLKTdcLhEQQi6nwg8OJYcyp 8pfxuR2pWg8wTG/HiEtzVYqYqF8q1nw2bqpSQad9etxpPI6k10x3UpbuG/I9yuYvwCrP NS/YGrc3iXk3C3YM2Oi0+jM2ECGoHeRA8hQTT87w/DuWk4nJ019AnHG92mYp+lUqoJ1C GKOwCgDVgjM1vkM3Gu8PsAjRgK3HVB6SwA+gDGQ0damr6NuKyWEmEl66oRDwgMdl1F1p eJJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789070775; x=1789675575; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CUgV2Sz6/P7makCPies8cUT1nvpwJR9dBUWK+1kW95Y=; b=NvJudYhp7zVJWzDudfpF+6L6Y6IIr/h/O0OxT95SibK1q1TpwowaRO2hLoY8gKxnfL CWWIFjbWIdZrIXwXgPrE9rSSQMjrGJQCFa1AwwwOOWhDfYOGcjxh2QlF/UPK1PqimKvi cOCine/OBhroQ3jA5NvB0sG4WrvZaBI5pIzH2OnZHydyofNE93h8yXE+6R2X49Bqa9sO EkvxEcVSCC4kSeZA3R4SZK4btyR9vM5n9WQP+apePg2FD+pxm95WJNp6syh3CTvxp5U3 NyMKILdfCrkp0Q+noU5Bi8VtRJqHC13eQjmJ9C7B04MyK/Bg3znded0N2DA/23FBMRi5 ZYxw== X-Gm-Message-State: AFuF++kYCvk1ulWkLgr/FvH9Pj2AwceKxqbR/gtO3AVqcISrV3nbq0ki LQDzY0YY62vZ+0Mq9lk838oAqX2zu1k6t92m6ifGQdwTwauyKdv9nhdLmfib6A== X-Gm-Gg: AYBFou2Fl1DWx95p6KHW8a9ymz1dcl8PWyl/301f0CVCingNCBoc4+UyyO45E+KhO2Q lQobOVzn6h4sa8dypxujIs4zFY04oZGzz1socGqpwmZuoZfOVPB5gApP/Dduw3c7e1igK2lKZeU F/RyFS/Hpvd//huupeaKPFeNgZ+dQ/9JKCgzLBJARh/Ke0ta0wWdDEgJpjTGpMQhuG/4Jkcntvt 9buWLqKSU5HqDk1rhVxu/dMEFhUAx61GcF2hfYi34TFBSaI9nuZNToPed3Yb8a6V0G3QK7Dw7eU wyCCSA9OmI7++S/vKvHZxbCc093Q8x/XkUcl6HSP2MMqnB3KcK/rFTST/AIQ9rIW4dN0lFcmh2f DReZQp+8/4T9dZKnvGazdyGFZHUHOOl4wl3Lgq5oZ2uGCLmgzOVThPLS6nX8xR5kNw0GVmsd7Uk xjtMHuvBAZex7pU/IM+bqiZ/NKCzXxTGCLi9Fr1E3+h45JdzrmGsFOxxklOOi5tjuV7tCTMh+MH aKZz7Szb5QPan88SjxEp0oiAoCOkC61tGK/PwKlEAujgjj5H8UWytWeqfrOSY9NPQ== X-Received: by 2002:a05:6a21:138c:b0:3da:11e2:b36c with SMTP id adf61e73a8af0-3dad295a03amr7441420637.27.1789070775028; Thu, 10 Sep 2026 13:06:15 -0700 (PDT) Received: from [192.168.0.158] (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4f1e434sm466446eec.22.2026.09.10.13.06.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2026 13:06:14 -0700 (PDT) Message-ID: Date: Thu, 10 Sep 2026 13:06:13 -0700 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/15] HID: hid-oxp: reject invalid Gen2 RGB status values To: Andrei Aldea , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Pavel Machek , linux-leds@vger.kernel.org References: <20260910032115.28669-1-andrei1998@gmail.com> <20260910032115.28669-5-andrei1998@gmail.com> Content-Language: en-US From: "Derek J. Clark" In-Reply-To: <20260910032115.28669-5-andrei1998@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/9/26 20:21, Andrei Aldea wrote: > Do not replace the cached RGB state with a Gen2 status report whose enable, > speed or hardware brightness fields are outside the supported ranges. > > Fixes: 252c4bf1d931 ("HID: hid-oxp: Add Second Generation RGB Control") > Assisted-by: LLM > Reviewed-by: Derek J. Clark > Signed-off-by: Andrei Aldea > --- > drivers/hid/hid-oxp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-oxp.c b/drivers/hid/hid-oxp.c > index 86a559c..c3cfa95 100644 > --- a/drivers/hid/hid-oxp.c > +++ b/drivers/hid/hid-oxp.c > @@ -415,6 +415,10 @@ static int oxp_hid_raw_event_gen_2(struct hid_device *hdev, > return 0; > > rgb_rep = (struct oxp_gen_2_rgb_report *)data; > + if (rgb_rep->enabled > OXP_FEAT_ENABLED || rgb_rep->speed > 9 || > + rgb_rep->brightness > 4) > + return 0; > + > /* Ensure we save monocolor as the list value */ > drvdata.rgb_effect = rgb_rep->effect == OXP_EFFECT_MONO_TRUE ? > OXP_EFFECT_MONO_LIST : I'm unable to test as my OneXPlayer F1 Pro is Gen 1 Reviewed-by: Derek J. Clark