From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 074ACC47404 for ; Wed, 9 Oct 2019 10:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C5AC20659 for ; Wed, 9 Oct 2019 10:29:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b="nApnUtTr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbfJIK3M (ORCPT ); Wed, 9 Oct 2019 06:29:12 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:60686 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbfJIK3M (ORCPT ); Wed, 9 Oct 2019 06:29:12 -0400 Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id B189EA02CF; Wed, 9 Oct 2019 12:29:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1570616949; bh=50Z9iz03hJ2oBnA63oAtg3v/o92mprCNV7tVOEIO5oo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=nApnUtTr1HYXDYzMEr94DH/MbYwGxpZz5EMiLivYS8o0zqmj1e9An4XJa02kkhpuh IMFuz4PwbdnqvPd7vZU+hpAxoeYRKIAixA5uCgf9qXCLhzocxA4mfp4tWc+K9hM12T f4bjEhD5T9fIKrPIuanbxODamXMVTNuR43cy6b/A= Subject: Re: [PATCH 1/5] Input: pixcir_i2c_ts - Remove unneeded gpio.h header file To: Dmitry Torokhov , Roger Quadros Cc: Fabio Estevam , linux-input@vger.kernel.org, jcbian@pixcir.com.cn References: <20191007121607.12545-1-festevam@gmail.com> <20191008184408.GG22365@dtor-ws> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: Date: Wed, 9 Oct 2019 12:29:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191008184408.GG22365@dtor-ws> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 08. 10. 19 20:44, Dmitry Torokhov wrote: > On Tue, Oct 08, 2019 at 01:11:15PM +0300, Roger Quadros wrote: >> Hi, >> >> On 07/10/2019 15:16, Fabio Estevam wrote: >>> The touchscreen device is a GPIO consumer, not a GPIO controller, >>> so there is no need to include . >>> >>> Remove the unneeded header file. >>> >>> Signed-off-by: Fabio Estevam >> >> For all 5 patches, >> >> Reviewed-by: Roger Quadros > > I guess we can also do this: > > Input: pixcir_i2c_ts - remove platform data > > From: Dmitry Torokhov > > Previous change moved platform data definition into the driver, making it > unusable for users. Given that we want to move away from custom platform > data structures, and always use device properties (DT, ACPI or static) to > configure devices, let's complete the removal. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/pixcir_i2c_ts.c | 100 +++++++---------------------- > 1 file changed, 25 insertions(+), 75 deletions(-) Compiled and boot tested the whole series including this patch from Dmitry on our imx6dl-yapp4-draco with Pixcir Tango C48. Everything still works for me, thanks! Tested-by: michal.vokac@ysoft.com