Re: [PATCH RESEND 5/7] mfd: cs40l26: Add support for CS40L26 core driver

[Richard Fitzgerald <rf@opensource.cirrus.com>]

On 11/02/2025 9:16 pm, Fred Treven wrote:
> On 2/5/25 04:34, Krzysztof Kozlowski wrote:
>> On 05/02/2025 00:18, Fred Treven wrote:
>>> Introduce support for Cirrus Logic Device CS40L26:
>>> A boosted haptic driver with integrated DSP and
>>> waveform memory with advanced closed loop algorithms
>>> and LRA protection.
>>>

<SNIP>

>>> +static const struct spi_device_id cs40l26_id_spi[] = {
>>> +    { "cs40l26a", 0 },
>>> +    { "cs40l27b", 1 },
>>
>> What are these 0 and 1?
> 
> I will make it clear that these are enumerating the different possible
> device variants.
> 
> 
>>
>>> +    {}
>>> +};
>>> +MODULE_DEVICE_TABLE(spi, cs40l26_id_spi);
>>> +
>>> +static const struct of_device_id cs40l26_of_match[] = {
>>> +    { .compatible = "cirrus,cs40l26a" },
>>> +    { .compatible = "cirrus,cs40l27b" },
>>
>> So devices are compatible? Or rather this is unsynced with other ID 
>> table.
> I'm not sure what you mean by this.
> 

cs40l26_id_spi[] has the 0/1 cookie values to indicate which part
variant is being instantiated. But cs40l26_of_match[] doesn't have
these cookie values to indicate which part ID was matched.