From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371C4C433EF for ; Mon, 18 Jul 2022 09:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233978AbiGRJZU (ORCPT ); Mon, 18 Jul 2022 05:25:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233663AbiGRJZT (ORCPT ); Mon, 18 Jul 2022 05:25:19 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAC9F19025; Mon, 18 Jul 2022 02:25:16 -0700 (PDT) Received: (Authenticated sender: contact@artur-rojek.eu) by mail.gandi.net (Postfix) with ESMTPA id 23266FF80B; Mon, 18 Jul 2022 09:25:12 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 18 Jul 2022 11:25:12 +0200 From: Artur Rojek To: Dmitry Torokhov Cc: Jonathan Cameron , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] Input: adc-joystick - fix ordering in adc_joystick_probe() In-Reply-To: References: Message-ID: X-Sender: contact@artur-rojek.eu Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 2022-07-09 06:35, Dmitry Torokhov wrote: > We should register the IIO buffer before we register the input device, > because as soon as the device is registered input handlers may attach > to > it, resulting in a call to adc_joystick_open() which makes use of the > said > buffer. > > Signed-off-by: Dmitry Torokhov > --- > > Not tested on hardware... Hi Dmitry, nice catch, thanks! I will verify the operation on hardware some time over the weekend. Small nitpick inline. With that changed: Acked-by: Artur Rojek > > drivers/input/joystick/adc-joystick.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/input/joystick/adc-joystick.c > b/drivers/input/joystick/adc-joystick.c > index 78ebca7d400a..e0cfdc84763f 100644 > --- a/drivers/input/joystick/adc-joystick.c > +++ b/drivers/input/joystick/adc-joystick.c > @@ -222,13 +222,6 @@ static int adc_joystick_probe(struct > platform_device *pdev) > if (error) > return error; > > - input_set_drvdata(input, joy); > - error = input_register_device(input); > - if (error) { > - dev_err(dev, "Unable to register input device\n"); > - return error; > - } > - > joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy); > if (IS_ERR(joy->buffer)) { > dev_err(dev, "Unable to allocate callback buffer\n"); > @@ -241,6 +234,14 @@ static int adc_joystick_probe(struct > platform_device *pdev) > return error; > } > > + input_set_drvdata(input, joy); > + > + error = input_register_device(input); > + if (error) { > + dev_err(dev, "Unable to register input device\n"); > + return error; > + } > + > return 0; Since this is now the last thing the function does, we can simplify the code a bit: ``` error = input_register_device(input); if (error) dev_err(dev, "Unable to register input device\n"); return error; ``` Cheers, Artur > } > > -- > 2.37.0.144.g8ac04bfd2-goog