From mboxrd@z Thu Jan 1 00:00:00 1970 From: Filipe =?ISO-8859-1?Q?La=EDns?= Subject: Re: [Resubmit] Read battery voltage from Logitech Gaming mice Date: Fri, 23 Aug 2019 15:29:23 +0100 Message-ID: References: <20190822201849.28924-1-pedro@pedrovanzella.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-xuWjDQq/RSZ7ZoquJLBK" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Pedro Vanzella , Benjamin Tissoires Cc: "open list:HID CORE LAYER" , Jiri Kosina , lkml List-Id: linux-input@vger.kernel.org --=-xuWjDQq/RSZ7ZoquJLBK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-08-23 at 10:22 -0400, Pedro Vanzella wrote: > I actually resubmitted by Filipe's request, since the patches weren't=20 > applying cleanly anymore. The idea was to apply these patches and in the= =20 > future refactor the code to use the feature discovery routines. Yes, I want to refactor everything so I though there was no point in us changing the patch set again. I did not review the first revision of the patch set so if that works for you (Benjamin) we can just merge that. > So we (you, me and Filipe) should probably come up with an action plan= =20 > here. The way I see it there are two issues here: one is adding this=20 > feature, and the other is refactoring to use feature discovery for all= =20 > features. There are advantages and disadvantages to doing one or another= =20 > first and we might want to discuss that. >=20 > By merging this first (probably after I resubmit it as a single squashed= =20 > patch) we get to test it a bit better and have a usable feature sooner.= =20 > Plenty of people have been requesting this and there is plenty of stuff= =20 > that can be built on top of it, but only once this is actually merged I= =20 > think. >=20 > On the other hand, by first refactoring the rest of the code to use=20 > 0x0001 we avoid some rework on this patch. It should be minor, as most= =20 > functions here do all the heavy lifting after the initial feature=20 > discovery, and are thus mostly independent from how that is done. >=20 > I'm happy either way, so just let me know what you guys decide. I am also fine either way so I think we should just re-send the first revision of your patch set as Benjamin requested. Thank you, Filipe La=C3=ADns --=-xuWjDQq/RSZ7ZoquJLBK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAl1f+D4ACgkQ+JPGdIFq qV2ezw/8CXhS7XgzWsqZOz7/x3H2JtpFxmu1CUKSz4RQde8zc0lygZKJumdkJqU0 8f6FeqBwLdAM+XHZg8qM+RHeg7zoXK9cKLVxiZphxo+bA0sDvAkjvczZ7juTyVQm oQUxrvSPUU69iUvVE7crB1IYDq49rWZAtXDMrrajXojciXmeipbqfiJZn+EclPrF rqZ2WFzlzpeM62pWCJ2vv9fxpBHWw8lGtdYPiehvE14Ot03ph3nVhzNSH8aHLptU bb+54QaEgDVXqyIdjvle0PUk2kRTbg+THb6anjXtaQQHcZj2Hibphnz36Pc7p1aU bWhGtyLgX3u5wEXS9jvXxCsnqt1yZ0QHt7ri03WVVBQQqFiq2f083c3y6uoqTQRi ya5EqpHHN1mtjLAKGodbO74n793kj5V2eLXY0TdjmrtDqluG8sPY7jm8zcU5RvBK V3ybuLGvkd9JHlpcgH4QKJ6VtVwhWPtz1DThjF8z69bhkWsijdtrzxFg8WXJnB+G IsnTwuZaa0ytvUa94X0160588+qK0AoMQ048EfS2M0NF9d7u41jEJoG7qK+gNzc9 3JN63STo9eFGkp6Bowzj6U/KtjqCOMKknr/pqZihyk1fSja9R6dhoWzb1BEK+gyA KXMU7Q48jGa26os47hA4m9Th6/D1aLIx5gxFVo3JpG1Q6A6cc5o= =G32C -----END PGP SIGNATURE----- --=-xuWjDQq/RSZ7ZoquJLBK--