* [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings
@ 2024-05-25 15:17 Jeff Johnson
2024-05-25 15:17 ` [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc Jeff Johnson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jeff Johnson @ 2024-05-25 15:17 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, kernel-janitors, kernel test robot,
Jeff Johnson
Clean up some 'make W=1' warnings
---
Jeff Johnson (2):
HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc
HID: intel-ish-hid: add MODULE_DESCRIPTION()
drivers/hid/intel-ish-hid/ishtp/bus.c | 2 ++
1 file changed, 2 insertions(+)
---
base-commit: 07506d1011521a4a0deec1c69721c7405c40049b
change-id: 20240525-kd-ishtp_wait_resume-95f01596b772
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc
2024-05-25 15:17 [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings Jeff Johnson
@ 2024-05-25 15:17 ` Jeff Johnson
2024-06-03 8:42 ` srinivas pandruvada
2024-05-25 15:17 ` [PATCH 2/2] HID: intel-ish-hid: add MODULE_DESCRIPTION() Jeff Johnson
2024-06-04 8:19 ` [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings Jiri Kosina
2 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnson @ 2024-05-25 15:17 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, kernel-janitors, kernel test robot,
Jeff Johnson
Fix the 'make W=1' kernel-doc warning:
drivers/hid/intel-ish-hid/ishtp/bus.c:853: warning: Function parameter or struct member 'dev' not described in 'ishtp_wait_resume'
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311060843.dXENYlGc-lkp@intel.com/
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index 03d5601ce807..f3042c4b8710 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -844,6 +844,7 @@ EXPORT_SYMBOL(ishtp_device);
/**
* ishtp_wait_resume() - Wait for IPC resume
+ * @dev: ishtp device
*
* Wait for IPC resume
*
--
2.42.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc
2024-05-25 15:17 ` [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc Jeff Johnson
@ 2024-06-03 8:42 ` srinivas pandruvada
0 siblings, 0 replies; 6+ messages in thread
From: srinivas pandruvada @ 2024-06-03 8:42 UTC (permalink / raw)
To: Jeff Johnson, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, kernel-janitors, kernel test robot
On Sat, 2024-05-25 at 08:17 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' kernel-doc warning:
>
> drivers/hid/intel-ish-hid/ishtp/bus.c:853: warning: Function
> parameter or struct member 'dev' not described in 'ishtp_wait_resume'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202311060843.dXENYlGc-lkp@intel.com/
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index 03d5601ce807..f3042c4b8710 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -844,6 +844,7 @@ EXPORT_SYMBOL(ishtp_device);
>
> /**
> * ishtp_wait_resume() - Wait for IPC resume
> + * @dev: ishtp device
> *
> * Wait for IPC resume
> *
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] HID: intel-ish-hid: add MODULE_DESCRIPTION()
2024-05-25 15:17 [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings Jeff Johnson
2024-05-25 15:17 ` [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc Jeff Johnson
@ 2024-05-25 15:17 ` Jeff Johnson
2024-06-03 8:43 ` srinivas pandruvada
2024-06-04 8:19 ` [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings Jiri Kosina
2 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnson @ 2024-05-25 15:17 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, kernel-janitors, Jeff Johnson
Fix the 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/intel-ish-hid/intel-ishtp.o
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index f3042c4b8710..cc76b295b632 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -932,4 +932,5 @@ static void __exit ishtp_bus_unregister(void)
module_init(ishtp_bus_register);
module_exit(ishtp_bus_unregister);
+MODULE_DESCRIPTION("ISHTP bus driver");
MODULE_LICENSE("GPL");
--
2.42.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] HID: intel-ish-hid: add MODULE_DESCRIPTION()
2024-05-25 15:17 ` [PATCH 2/2] HID: intel-ish-hid: add MODULE_DESCRIPTION() Jeff Johnson
@ 2024-06-03 8:43 ` srinivas pandruvada
0 siblings, 0 replies; 6+ messages in thread
From: srinivas pandruvada @ 2024-06-03 8:43 UTC (permalink / raw)
To: Jeff Johnson, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, kernel-janitors
On Sat, 2024-05-25 at 08:17 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/intel-
> ish-hid/intel-ishtp.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index f3042c4b8710..cc76b295b632 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -932,4 +932,5 @@ static void __exit ishtp_bus_unregister(void)
> module_init(ishtp_bus_register);
> module_exit(ishtp_bus_unregister);
>
> +MODULE_DESCRIPTION("ISHTP bus driver");
> MODULE_LICENSE("GPL");
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings
2024-05-25 15:17 [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings Jeff Johnson
2024-05-25 15:17 ` [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc Jeff Johnson
2024-05-25 15:17 ` [PATCH 2/2] HID: intel-ish-hid: add MODULE_DESCRIPTION() Jeff Johnson
@ 2024-06-04 8:19 ` Jiri Kosina
2 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2024-06-04 8:19 UTC (permalink / raw)
To: Jeff Johnson
Cc: Srinivas Pandruvada, Benjamin Tissoires, linux-input,
linux-kernel, kernel-janitors, kernel test robot
On Sat, 25 May 2024, Jeff Johnson wrote:
> Clean up some 'make W=1' warnings
>
> ---
> Jeff Johnson (2):
> HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc
> HID: intel-ish-hid: add MODULE_DESCRIPTION()
>
> drivers/hid/intel-ish-hid/ishtp/bus.c | 2 ++
> 1 file changed, 2 insertions(+)
> ---
Applied, thank you.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-04 8:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-25 15:17 [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings Jeff Johnson
2024-05-25 15:17 ` [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc Jeff Johnson
2024-06-03 8:42 ` srinivas pandruvada
2024-05-25 15:17 ` [PATCH 2/2] HID: intel-ish-hid: add MODULE_DESCRIPTION() Jeff Johnson
2024-06-03 8:43 ` srinivas pandruvada
2024-06-04 8:19 ` [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).