From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>,
George Anthony Vernon <contact@gvernon.com>,
dmitry.torokhov@gmail.com, skhan@kernel.org
Cc: linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH 3/3] input: docs: Fix Amiga joysticks grammar & formatting
Date: Mon, 26 May 2025 20:56:32 +0700 [thread overview]
Message-ID: <cb2d5cbd-d1e5-4a71-a24d-d02604c4016a@gmail.com> (raw)
In-Reply-To: <87a56za67l.fsf@trenco.lwn.net>
On 5/26/25 19:48, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>
>> On Mon, May 26, 2025 at 02:14:43AM +0100, George Anthony Vernon wrote:
>>> Make small grammar fixes to Amiga joystick documentation.
>>>
>>> Also make heading adornments compliant with the guidelines to improve
>>> organisation of the page.
>>
>> Split up these two changes into separate patches.
>
> The word "also" in a changelog is indeed a hint that a patch is doing
> too many things.
>
> For a simple patch like this, though, I would not force a resend just
> for that.
>
Do you mean keeping the patch as-is?
>>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>>> -Amiga joystick extensions
>>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>>> +===============
>>> +Amiga joysticks
>>> +===============
>>
>> I would prefer to keep section adornments in this doc as-is, though.
>
> ...and why...? We have a standard progression, why not use it?
>
I'm leaning towards following doc-specific convention (i.e. on this
doc). I could adapt to it, but some time later when I re-read the
source I might be semantically confused.
Thanks.
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2025-05-26 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 1:14 [PATCH 0/3] Multiple fixes to Amiga joystick documentation George Anthony Vernon
2025-05-26 1:14 ` [PATCH 1/3] input: docs: Fix broken table formatting George Anthony Vernon
2025-05-26 2:34 ` Bagas Sanjaya
2025-05-26 1:14 ` [PATCH 2/3] input: docs: Correct Amiga 4-jstick adapter pinout George Anthony Vernon
2025-05-26 1:14 ` [PATCH 3/3] input: docs: Fix Amiga joysticks grammar & formatting George Anthony Vernon
2025-05-26 2:43 ` Bagas Sanjaya
2025-05-26 12:48 ` Jonathan Corbet
2025-05-26 13:56 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2d5cbd-d1e5-4a71-a24d-d02604c4016a@gmail.com \
--to=bagasdotme@gmail.com \
--cc=contact@gvernon.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).