From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93F934CFDA; Tue, 10 Feb 2026 11:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770721471; cv=none; b=R2bFSvo1FU+dxEZfiD6WzSgf1HH2XUx6fyw5W1h1vnwiAgLdjWCOhPBJat8Sst1pD5xSbjTsfh7lDm01v5703cQcw5c+FEOiC6y1Ut7f6+3mKknpcJlLZmF8BK9s6kvAcM83iEwQnXjjVUT4CJnghBEz8GTvZo7vD+/9WKcX3TA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770721471; c=relaxed/simple; bh=vQO8UVkAmKybr8Co6MHBA3L4CYbVXurm1fpp7G9KGr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NzFfL7CqZp7fvZVo/GjnaWPUKkcPLGO17IDEmT66+8Om8tzHNoeiKzEf/cI+x/yWPeS4dT6xvSAo0zK9Y2n9j8pN/gpzmuxrEtPzxLt+5mO+zimrQL5T6Gh3XQ1QLSd6U/vTVGYS1DONztRDdJWdHlZCEstQhBYgExw9TNkw7Js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XadKqi7Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XadKqi7Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F82C116C6; Tue, 10 Feb 2026 11:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770721471; bh=vQO8UVkAmKybr8Co6MHBA3L4CYbVXurm1fpp7G9KGr4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XadKqi7QTLDRw3d687ZK+402V77QfY4e0sCfdwKM7WUDA1ZA204F9wuE49PisIQaE K+vsYK8s0K0KTtrmQByw9JOC/l6+QvHjKeeIfU7ebnapHpn9Cj0NhKQApLGzeXe867 prQvQGRSo8rPLO+gte8hyKVD1svaEQjJD3X0prY9JYhBn50CuYVHRpvkN/SR+4C5DF eH6UPiDye9iLXJ7zy53LxSeBvzDTzTbXBChd6xjK8V22aEtlza1tktMpOzC5edHw+w dZRMQjUQ0jzKsu6T8ZSBcWBpQGQh9eYZJD2EKa0vNZWDt+RwKd+F1Fw2cCgsigthx0 lqj1bBHE8ZN0g== Message-ID: Date: Tue, 10 Feb 2026 12:04:26 +0100 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/9] dt-bindings: mfd: document ASUS Transformer EC To: Svyatoslav Ryhel Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Ion Agorria , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org References: <20260209104407.116426-1-clamor95@gmail.com> <20260209104407.116426-4-clamor95@gmail.com> <20260210-sexy-grumpy-sambar-44edd2@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/02/2026 11:59, Svyatoslav Ryhel wrote: >>>>> + asus,clear-factory-mode: >>>>> + type: boolean >>>>> + description: clear Factory Mode bit in EC control register >>>> >>>> Why would this be a static/fixed property over lifecycle of all devices? >>>> >>> >>> Specify pls. >> >> Provide rationale why we need to clear it every time, not once. Or any >> other rationale why we would accept that property. >> > > Cause it is done by original Asus code and Asus did not provide > schematic or any data apart from downstream source regarding this EC. So that's a no. downstream code which is poor quality, not following DT rules at all, is never an argument for a DT property. > >>> >>>>> + >>>>> + battery: >>>>> + type: object >>>>> + $ref: /schemas/power/supply/power-supply.yaml >>>>> + unevaluatedProperties: false >>>>> + >>>>> + properties: >>>>> + compatible: >>>>> + const: asus,ec-battery >>>>> + >>>>> + required: >>>>> + - compatible >>>>> + >>>>> + charger: >>>>> + type: object >>>>> + $ref: /schemas/power/supply/power-supply.yaml >>>>> + additionalProperties: false >>>>> + >>>>> + properties: >>>>> + compatible: >>>>> + const: asus,ec-charger >>>>> + >>>>> + monitored-battery: true >>>>> + >>>>> + required: >>>>> + - compatible >>>>> + >>>>> + keyboard-ext: >>>>> + type: object >>>>> + description: top row of multimedia keys >>>>> + additionalProperties: false >>>>> + >>>>> + properties: >>>>> + compatible: >>>>> + const: asus,ec-keys >>>>> + >>>>> + required: >>>>> + - compatible >>>>> + >>>>> + led: >>>>> + type: object >>>>> + additionalProperties: false >>>>> + >>>>> + properties: >>>>> + compatible: >>>>> + const: asus,ec-led >>>>> + >>>>> + required: >>>>> + - compatible >>>>> + >>>>> + serio: >>>> >>>> All of these children are pointless - no resources. Drop all of them, >>>> it's btw explicitly documented rule in writing bindings. >>>> >>> >>> They are all needed to be able to disable them individually from the >>> device tree if needed. >> >> They should not be disabled from DT, so they are not valid here. The >> given EC for given device is fixed/static. Does not change. >> > > Have you considered a possibility that function may be > disabled/unrouted within the controller. By the vendor. And then it is implied by the compatible, so no need for any of that. Otherwise, if it is not specific per device, then specifying it for DTS for all devices would make no sense. Best regards, Krzysztof