From: Markus Elfring <Markus.Elfring@web.de>
To: Abdun Nihaal <nihaal@cse.iitm.ac.in>,
linux-input@vger.kernel.org,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH] HID: playstation: Fix memory leak in dualshock4_get_calibration_data()
Date: Mon, 10 Nov 2025 18:49:01 +0100 [thread overview]
Message-ID: <cc4923d4-a24c-47ff-876d-0fddc0b8ad1e@web.de> (raw)
In-Reply-To: <20251110171552.95466-1-nihaal@cse.iitm.ac.in>
> The memory allocated for buf is not freed in the error paths when
> ps_get_report() fails. Free buf before jumping to transfer_failed label
Would an additional label become helpful for this function implementation?
Regards,
Markus
next prev parent reply other threads:[~2025-11-10 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 17:15 [PATCH] HID: playstation: Fix memory leak in dualshock4_get_calibration_data() Abdun Nihaal
2025-11-10 17:49 ` Markus Elfring [this message]
2025-11-11 11:23 ` Abdun Nihaal
2025-11-18 17:07 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc4923d4-a24c-47ff-876d-0fddc0b8ad1e@web.de \
--to=markus.elfring@web.de \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nihaal@cse.iitm.ac.in \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox