From: "Andrew Victor" <avictor.za@gmail.com>
To: Justin Waters <justin.waters@timesys.com>
Cc: linux-input@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk,
dmitry.torokhov@gmail.com, linux@maxim.org.za
Subject: Re: [PATCH 2/2] atmel_tsadcc: Add board specific information for touchscreen driver
Date: Sat, 26 Apr 2008 00:29:09 +0200 [thread overview]
Message-ID: <cd73a99e0804251529g68e88165x3863c4257618ee00@mail.gmail.com> (raw)
In-Reply-To: <1209149798-20418-3-git-send-email-justin.waters@timesys.com>
hi Justin,
> +static u64 atmel_tsadcc_dmamask = 0xffffffffUL;
Rather use DMA_BIT_MASK(32).
> + /* These values work with a 100 MHz Master Clock for the ADC */
> + .prescaler = 0xC, /* 3.846 MHz Clock */
> + .debounce = 0xE, /* 4.2 ms debounce */
> + .tsshtim = 0x3, /* 1.04 us Sample Hold time */
> + .startup = 0x13, /* 41 us Startup Time */
What is the impact of a different Master Clock rate? This devices.c
file is intended to be board-independent.
Wouldn't it be better for the driver to call clk_get_rate() and
calculate "good" values for these?
> + .coherent_dma_mask = 0xffffffff,
Similarly, DMA_BIT_MASK(32).
Regards,
Andrew Victor
next prev parent reply other threads:[~2008-04-25 22:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 18:56 [PATCH 0/2] Atmel AT91SAM9RL Touchscreen Driver Justin Waters
2008-04-25 18:56 ` [PATCH 1/2] atmel_tsadcc: Device driver for AT91SAM9RL Touchscreen Justin Waters
2008-04-25 18:56 ` [PATCH 2/2] atmel_tsadcc: Add board specific information for touchscreen driver Justin Waters
2008-04-25 22:29 ` Andrew Victor [this message]
2008-04-25 20:34 ` [PATCH 1/2] atmel_tsadcc: Device driver for AT91SAM9RL Touchscreen Dmitry Torokhov
2008-04-25 21:10 ` Russell King - ARM Linux
2008-04-25 21:37 ` Justin Waters
2008-04-25 22:52 ` David Brownell
2008-06-05 13:49 ` Haavard Skinnemoen
2008-04-25 22:16 ` Andrew Victor
2008-04-28 5:55 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd73a99e0804251529g68e88165x3863c4257618ee00@mail.gmail.com \
--to=avictor.za@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=justin.waters@timesys.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux@maxim.org.za \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).