From: Marek Vasut <marex@denx.de>
To: Frank Li <Frank.Li@nxp.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Hasemeyer <markhas@chromium.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: imx@lists.linux.dev
Subject: Re: [PATCH v4 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml
Date: Tue, 20 Aug 2024 05:30:04 +0200 [thread overview]
Message-ID: <cd8b6c1e-f7d7-4db2-b178-7391e3111237@denx.de> (raw)
In-Reply-To: <20240819180535.368902-1-Frank.Li@nxp.com>
On 8/19/24 8:05 PM, Frank Li wrote:
[...]
> + ti,keep-vref-on:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + set to keep Vref on for differential measurements as well.
Please start sentence with uppercase letter.
> + ti,pendown-gpio-debounce:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Platform specific debounce time for the pendown-gpio.
> +
> + ti,penirq-recheck-delay-usecs:
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description:
> + If set to non-zero, after samples are taken this delay is applied and
> + penirq is rechecked, to help avoid false events. This value is
> + affected by the material used to build the touch layer.
> +
> + ti,pressure-max:
> + deprecated: true
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description:
> + Maximum reported pressure value.
> +
> + ti,pressure-min:
> + deprecated: true
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description:
> + Minimum reported pressure value (threshold).
> +
> + ti,settle-delay-usec:
> + $ref: /schemas/types.yaml#/definitions/uint16
> + description:
> + Settling time of the analog signals; a function of Vcc and the
> + capacitance on the X/Y drivers. If set to non-zero, two samples are
> + taken with settle_delay us apart, and the second one is used. ~150
> + uSec with 0.01uF caps.
> +
> + ti,swap-xy:
> + deprecated: true
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + swap x and y axis.
DTTO
With those two fixed:
Reviewed-by: Marek Vasut <marex@denx.de>
Thanks !
prev parent reply other threads:[~2024-08-20 3:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 18:05 [PATCH v4 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml Frank Li
2024-08-20 3:30 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd8b6c1e-f7d7-4db2-b178-7391e3111237@denx.de \
--to=marex@denx.de \
--cc=Frank.Li@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).