From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ma Subject: Re: [PATCH 2/2] Input: synaptics - remove X240 from the topbuttonpad list Date: Thu, 23 May 2019 13:02:09 +0800 Message-ID: References: <20190519072711.2592-1-aaron.ma@canonical.com> <20190519072711.2592-2-aaron.ma@canonical.com> <20190521050850.GC183429@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Tissoires , Dmitry Torokhov Cc: "open list:HID CORE LAYER" , lkml , Christopher Heiny , Andrew Duggan , Hans de Goede List-Id: linux-input@vger.kernel.org On 5/21/19 2:49 PM, Benjamin Tissoires wrote: > A quick google image search showed that the X240 had 2 versions: one > with the top software buttons, one without. > > And this definitively rings a bell. I am sure we asked Lenovo and > Synaptics to change the PnPID when they would do such a change, but > they "forgot" during the *40 series refresh. > We have code in place to fix the reported ranges of the coordinates, > and we had to check against the board id (see min_max_pnpid_table[] in > synaptics.c). > Unfortunately, X240 (LEN0035) is not part of this table, so I don't > know which refresh of the board ID has implemented the non top > software buttons. After double confirm from Lenovo, looks like they mixed up with touchpads on X240/X240s. For now only one user reported this LEN0035 doesn't work on SMBus mode. module parameter can be a workaround. Maybe some touchpads with software top buttons are working well on SMBus. Let's keep eyes on this issue for now. Regards, Aaron > > Cheers, > Benjamin