From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=1/AT=52=vger.kernel.org=linux-input-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 553D7C2BA19
	for <linux-input@archiver.kernel.org>; Fri, 10 Apr 2020 02:54:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 3597220730
	for <linux-input@archiver.kernel.org>; Fri, 10 Apr 2020 02:54:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726571AbgDJCys (ORCPT <rfc822;linux-input@archiver.kernel.org>);
        Thu, 9 Apr 2020 22:54:48 -0400
Received: from cmccmta3.chinamobile.com ([221.176.66.81]:4471 "EHLO
        cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725987AbgDJCyr (ORCPT
        <rfc822;linux-input@vger.kernel.org>); Thu, 9 Apr 2020 22:54:47 -0400
Received: from spf.mail.chinamobile.com (unknown[172.16.121.13]) by rmmx-syy-dmz-app09-12009 (RichMail) with SMTP id 2ee95e8fdfe34e0-f7507; Fri, 10 Apr 2020 10:54:28 +0800 (CST)
X-RM-TRANSID: 2ee95e8fdfe34e0-f7507
X-RM-TagInfo: emlType=0                                       
X-RM-SPAM-FLAG: 00000000
Received: from [172.20.21.224] (unknown[112.25.154.146])
        by rmsmtp-syy-appsvr07-12007 (RichMail) with SMTP id 2ee75e8fdfe1888-eb86f;
        Fri, 10 Apr 2020 10:54:28 +0800 (CST)
X-RM-TRANSID: 2ee75e8fdfe1888-eb86f
Subject: Re: Input: ep93xx_keypad: Checking for a failed
 platform_get_irq()call in ep93xx_keypad_probe()
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Markus Elfring <Markus.Elfring@web.de>
Cc:     linux-input@vger.kernel.org, Allison Randal <allison@lohutok.net>,
        Arnd Bergmann <arnd@arndb.de>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Olof Johansson <olof@lixom.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <11aecb68-d243-2eeb-0cc8-50e1ec22bd71@web.de>
 <20200409204819.GR75430@dtor-ws>
From:   Tang Bin <tangbin@cmss.chinamobile.com>
Message-ID: <ce38d025-e84a-55cf-bf87-3293aa692ee5@cmss.chinamobile.com>
Date:   Fri, 10 Apr 2020 10:56:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200409204819.GR75430@dtor-ws>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-input-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-input.vger.kernel.org>
X-Mailing-List: linux-input@vger.kernel.org

Hi Dmitry:

On 2020/4/10 4:48, Dmitry Torokhov wrote:
> Platform code historically allowed creating IRQ resources with IRQ
> number 0 to indicate "no interrupt assigned", so this driver tries to
> filter out such conditions. The negative IRQs (errors) will be rejected
> by request_irq() but I guess we can lose -EPROBE_DEFER. We could do
>
> 	if (keypad->irq <= 0) {
> 		err = keypad->irq ?: -ENXIO : keypad->irq;
> 		goto failed_free;
> 	}

I have been aware of this problem for several days, and by doing 
experiments on the hardware, I have found the following ways that maybe 
suitable：

     if (keypad->irq <= 0) {
         err = keypad->irq ? : -ENXIO;
         goto failed_free;
     }
     or
     if (keypad->irq <= 0) {
         err = keypad->irq < 0 ? keypad->irq : -ENXIO;
         goto failed_free;
     }

If you think it's usefull, I will send this patch to fix this problem.

Thanks

Tang Bin