From: Neil Armstrong <neil.armstrong@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Jeff LaBundy <jeff@labundy.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v14 2/4] Input: add core support for Goodix Berlin Touchscreen IC
Date: Mon, 29 Jan 2024 10:02:33 +0100 [thread overview]
Message-ID: <cef1e9ec-1aae-400f-bb30-05d43c6211f4@linaro.org> (raw)
In-Reply-To: <98ed4ee9-f381-43a0-a5cc-523ad108b374@linaro.org>
On 12/01/2024 16:08, Neil Armstrong wrote:
> Hi Dmitry,
>
> On 11/01/2024 08:20, Dmitry Torokhov wrote:
>> Hi Neil,
>>
>> On Thu, Dec 21, 2023 at 04:21:20PM +0100, Neil Armstrong wrote:
>>> Add initial support for the new Goodix "Berlin" touchscreen ICs.
>>
>> Thank you very much for explaining how reading of additional contacts
>> and checksum works, it makes sense now.
>>
>> I was a bit unhappy about number of times we copy/move the data over;
>> could you please try the patch below to see if the device still works
>> with it?
>
> Sure, I'll test it and report you.
Ok it still works fine!
Sending v15 with those changes and rebased on latest linux-next.
Thanks,
Neil
>
>>
>> I also shortened some #defines and defines some additional structures.
>> Also as far as I can see not everything needs to be packed as the data
>> is naturally aligned on the word boundaries.
>
> Great, thank!
>
> Neil
>
>>
>> Thanks!
>>
>
next prev parent reply other threads:[~2024-01-29 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 15:21 [PATCH v14 0/4] Input: add initial support for Goodix Berlin touchscreen IC Neil Armstrong
2023-12-21 15:21 ` [PATCH v14 1/4] dt-bindings: input: document Goodix Berlin Touchscreen IC Neil Armstrong
2023-12-21 15:21 ` [PATCH v14 2/4] Input: add core support for " Neil Armstrong
2024-01-11 7:20 ` Dmitry Torokhov
2024-01-12 15:08 ` Neil Armstrong
2024-01-29 9:02 ` Neil Armstrong [this message]
2023-12-21 15:21 ` [PATCH v14 3/4] Input: goodix-berlin - add I2C " Neil Armstrong
2023-12-21 15:21 ` [PATCH v14 4/4] Input: goodix-berlin - add SPI " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef1e9ec-1aae-400f-bb30-05d43c6211f4@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=jeff@labundy.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).