Linux Input/HID development
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: linux-input@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - add support for polling on devices without IRQ line
Date: Mon, 30 Jun 2025 11:44:03 +0200	[thread overview]
Message-ID: <cfa155f9-573a-479a-b8db-89c3bb077114@mailbox.org> (raw)
In-Reply-To: <6kqp24t5c23vcvv7wuirkjz6a5s3daacifw37rb5554v4uqeit@jzsinkx6qb7r>

On 6/30/25 3:32 AM, Dmitry Torokhov wrote:
> Hi Marek,

Hi,

> On Tue, Jun 10, 2025 at 02:54:12AM +0200, Marek Vasut wrote:
>> Add the capability of polling the touch controller for events every
>> 16ms, which is useful on hardware that did integrate this touch
>> controller, but did not integrate the IRQ line, like the RasPi .
>>
>> Make use of the generic input poller code. Factor out the code
>> from goodix_ts_irq_handler() into generic goodix_ts_handler(), so
>> it can be used both by the IRQ handler and poller callback.
>>
>> Use of_client->irq to find out whether the interrupt line is present
>> or not, independent of whether this is OF or ACPI system. It is not
>> possible to register poller in case request_irq() fails, because the
>> request_irq() in this driver is deliberately called after the input
>> device was registered, and registering the generic poller at that point
>> is too late already.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> 
> There was another version of this patch that was submitted and reviewed
> by Hans, so I merged it.

Is it the following patch, with malformed commit message and some odd 
"LF-15225" subject tag ?

https://patchwork.kernel.org/project/linux-input/patch/20250522020418.1963422-1-qijian.guo@nxp.com/

> BTW I think this version would end up trying to disable IRQ0...
How come ?

  reply	other threads:[~2025-06-30  9:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  0:54 [PATCH] Input: goodix - add support for polling on devices without IRQ line Marek Vasut
2025-06-30  1:32 ` Dmitry Torokhov
2025-06-30  9:44   ` Marek Vasut [this message]
2025-06-30 15:40     ` Dmitry Torokhov
2025-07-30 22:14       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfa155f9-573a-479a-b8db-89c3bb077114@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox